Skip to content

innounp: Update to version 2.70.1, fix autoupdate URL - #8327

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
akapur:fix-innounp-url
Jul 23, 2026
Merged

innounp: Update to version 2.70.1, fix autoupdate URL#8327
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
akapur:fix-innounp-url

Conversation

@akapur

@akapur akapur commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • innounp's download URL 404s: upstream (jrathlev/InnoUnpacker-Windows-GUI) renamed release assets from a static innounp-2.zip to versioned filenames (innounp-267.zip, innounp-270.zip, ...), breaking both the manifest's url and autoupdate.url.
  • Bumps to the latest upstream release, 2.70.1, and points url/hash at the current asset (innounp-270.zip).
  • Fixes autoupdate.url to use $majorVersion$minorVersion so future version bumps track the new naming convention automatically — verified against both currently published assets: 2.67.11innounp-267.zip, 2.70.1innounp-270.zip.

Test plan

  • Downloaded innounp-270.zip directly and verified the sha256 hash matches the manifest.
  • bin/checkver.ps1 -App innounp resolves cleanly to 2.70.1 against the updated manifest.
  • bin/formatjson.ps1 -App innounp produces no diff (formatting unchanged).
  • Installed locally via scoop install from this manifest and confirmed innounp.exe runs (innounp - the Inno Setup Unpacker, version 2.70.1 (2026-07-21)).

Upstream (jrathlev/InnoUnpacker-Windows-GUI) renamed release assets from
a static innounp-2.zip to versioned filenames (innounp-267.zip,
innounp-270.zip, ...), breaking the manifest's hardcoded url/autoupdate
url with a 404.

- Bump to the latest release, 2.70.1
- Point url/hash at the current asset (innounp-270.zip)
- Fix autoupdate.url to use $majorVersion$minorVersion so future
  bumps track the new naming convention automatically (verified against
  both existing assets: 2.67.11 -> innounp-267.zip, 2.70.1 -> innounp-270.zip)
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Changes

InnoUnp release metadata

Layer / File(s) Summary
Release metadata and autoupdate pattern
bucket/innounp.json
The manifest is updated from version 2.67.11 to 2.70.1, with matching download URL and hash changes; the autoupdate URL now uses version placeholders.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the manifest bump and autoupdate URL fix.
Description check ✅ Passed The description includes a clear summary and test plan, and mostly matches the template.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@arvdk

arvdk commented Jul 21, 2026

Copy link
Copy Markdown

Closes #8330

@z-Fng z-Fng changed the title innounp: Fix broken download URL, update to 2.70.1 innounp: Update to version 2.70.1, fix autoupdate URL Jul 23, 2026
@z-Fng
z-Fng merged commit 36e4b1d into ScoopInstaller:master Jul 23, 2026
3 checks passed
@z-Fng

z-Fng commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

innounp

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@chadlwilson

chadlwilson commented Jul 23, 2026

Copy link
Copy Markdown

Thanks for fixing this for now.

Was thinking about making this more stable to not use refs/heads such that every release doesn't break user installs in some way.

However even if the author used GitHub releases or tags they'd need to enable immutable releases or promise to not re-upload binaries to a given release (seems the earlier breakages were caused by them doing just that, and there is some evidence in commit history of re-uploading binaries without changing version, or for new patch versions) Tags are entirely mutable in Git, and both tags/releases are mutable by default in GitHub so not a huge guarantee either.

If the author is committing binaries to Git (sigh) as the most reliable distribution mechanism, it does always have raw permalinks available by commit SHAs (with path), e.g

https://raw.githubusercontent.com/jrathlev/InnoUnpacker-Windows-GUI/807426708fd4a7ab260ff0a1c09e239f53c97782/innounp-2/bin/innounp-270.zip

If the amount of breakage from auto-updates or maintainer changes is greater than the frequency of needed updates, I wonder if better to turn auto-updates off?

Ideas on Auto-updates

I thought perhaps something like this might work off the folder's commit ATOM feed at https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commits/master/innounp-2/bin.atom to capture the commit SHA and version, but even the commit comments don't include the correct version number (2.70.1), and it's probably just as unreliable to depend on commit comments anyway.

(treat as pseudo-code, don't think the <commitsha> can be transferred to autoupdate like the below)

  "checkver": {
      "url": "https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commits/master/innounp-2/bin.atom",
      "regex": "(?si)Grit::Commit/(?<commitsha>[0-9a-f]{40}).*?update.*? ((2)\\.(\\d+)(\\.(\\d+))?)",
      "replace": "${3}.${4}.${5}"
  },
  "autoupdate": {
        "url": "https://raw.githubusercontent.com/jrathlev/InnoUnpacker-Windows-GUI/$commitSha/innounp-2/bin/innounp-$majorVersion$minorVersion.zip"
    }
image

Snippet from the commit feed for posterity:

<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
  <id>tag:github.com,2008:/jrathlev/InnoUnpacker-Windows-GUI/commits/master/innounp-2/bin</id>
  <link type="text/html" rel="alternate" href="https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commits/master/innounp-2/bin"/>
  <link type="application/atom+xml" rel="self" href="https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commits/master/innounp-2/bin.atom"/>
  <title>Recent Commits to InnoUnpacker-Windows-GUI:master</title>
  <updated>2026-07-21T14:00:29Z</updated>
  <entry>
    <id>tag:github.com,2008:Grit::Commit/807426708fd4a7ab260ff0a1c09e239f53c97782</id>
    <link type="text/html" rel="alternate" href="https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commit/807426708fd4a7ab260ff0a1c09e239f53c97782"/>
    <title>
        Update to 2.70
    </title>
    <updated>2026-07-21T14:00:29Z</updated>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/40795066?s=30&amp;v=4"/>
    <author>
      <name>jrathlev</name>
      <uri>https://github.com/jrathlev</uri>
    </author>
    <content type="html">
      &lt;pre style=&#39;white-space:pre-wrap;width:81ex&#39;&gt;Update to 2.70&lt;/pre&gt;
    </content>
  </entry>
  <entry>
    <id>tag:github.com,2008:Grit::Commit/09de682baeb9c6f3b103d85f411265de19c53665</id>
    <link type="text/html" rel="alternate" href="https://github.com/jrathlev/InnoUnpacker-Windows-GUI/commit/09de682baeb9c6f3b103d85f411265de19c53665"/>
    <title>
        Update to 2.67.11
    </title>
    <updated>2026-07-13T15:01:51Z</updated>
    <media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/40795066?s=30&amp;v=4"/>
    <author>
      <name>jrathlev</name>
      <uri>https://github.com/jrathlev</uri>
    </author>
    <content type="html">
      &lt;pre style=&#39;white-space:pre-wrap;width:81ex&#39;&gt;Update to 2.67.11&lt;/pre&gt;
    </content>
  </entry>
  ...

z-Fng added a commit to ScoopInstaller/Versions that referenced this pull request Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

innounp@2.67.11: download via aria2 failed innounp@2.67.11: download via aria2 failed [Bug]: innounp@2.67.11 wrong asset url

5 participants