devcontainer-cli: Add version 0.87.0 - #8320
Conversation
- References the official CLI from https://github.com/devcontainers/cli - Uses npm registry as download source - Depends on nodejs runtime (not bundled) - Entry point: package/devcontainer.js via node shim
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughChangesDevcontainer CLI
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "node.exe", | ||
| "devcontainer", | ||
| "$dir\\devcontainer.js" |
There was a problem hiding this comment.
It requires a Node.js runtime, please install it with package manager of NPM ecosystem.
I would advise against wrapping packages installed through npm, pacman, or pip into a Scoop manifest.
|
I understand the concern about wrapping npm packages, but I think this case is different from a typical 1. The official distribution IS self-contained, not npm-first. The project's own install script (https://github.com/devcontainers/cli/blob/main/scripts/install.sh) downloads and bundles a specific Node.js runtime alongside the CLI. It never asks the user to 2. The manifest is a self-contained tool, not an npm wrapper. The manifest downloads two things: a Node.js runtime zip and the CLI tarball. It extracts them side by side and creates a thin 3. There are precedents in Main bucket for tools that bundle their own runtime. Several Main bucket manifests ship tools that include their own runtime or are downloaded from language-specific registries as pre-built archives — the key distinction is whether the manifest delegates to a foreign package manager at install time vs. uses a registry URL as a download source. This manifest does the latter. What I'm proposing: The Would this be acceptable for Main, given that the tool's own distribution strategy is self-contained rather than npm-native? |
Most npm packages can do this as well, like Gemini-CLI.
Scoop does not offer any clear advantages for managing npm or Python packages. It is usually better to use their dedicated package managers instead. My personal advice is to avoid using Scoop as a universal replacement for all tools. Furthermore, our community is not very active at the moment. Adding a package to the official bucket that is installed via npm would likely lead to more similar requests, which would increase our maintenance overhead. If you still insist on installing it via Scoop, please use a community-maintained bucket or set up your own personal bucket for it. |
|
Ok, thanks for your reply. I'll reconsider my demands. |
Closes #8319
<manifest-name[@version]|chore>: <general summary of the pull request>