Skip to content

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jun 11, 2025

🚀 Pull Request

Description

The function _is_lat_lon fails with an AttributeError if the coordinate variable has non-string units.

This PR adapts this function so it can handle this case.

Fixes #6505


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@schlunma schlunma changed the title Fix Loading files with coordinates that have non-string units fails Fix loading files with coordinates that have non-string units fails Jun 11, 2025
@schlunma schlunma changed the title Fix loading files with coordinates that have non-string units fails Fix loading files with coordinates that have non-string units Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (3fe8169) to head (d419ad9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6506   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          90       90           
  Lines       23908    23908           
  Branches     4459     4459           
=======================================
  Hits        21487    21487           
  Misses       1669     1669           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlunma LGTM 👍

@bjlittle bjlittle merged commit 37852b9 into SciTools:main Jun 18, 2025
22 checks passed
@schlunma schlunma deleted the load_nc_with_float_units branch June 23, 2025 10:09
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading files with coordinates that have non-string units fails
2 participants