PERF: vectorize shapely_to_path coordinate extraction#2693
Merged
Conversation
greglucas
commented
Jul 5, 2026
| return Path(np.empty([0, 2])) | ||
| elif isinstance(shape, sgeom.LinearRing): | ||
| return Path(np.column_stack(shape.xy), closed=True) | ||
| return Path(shapely.get_coordinates(shape), closed=True) |
Contributor
Author
There was a problem hiding this comment.
get_coordinates() defaults to 2d arrays, so we can use it directly here even if someone passes a geometry with Z.
https://shapely.readthedocs.io/en/2.1.2/reference/shapely.get_coordinates.html
QuLogic
approved these changes
Jul 6, 2026
Rather than pulling out each sub-geometry .xy's coordinates, we can do one get_coordinates() call and fill in the codes all at once.
greglucas
force-pushed
the
perf/vectorize-shapely-to-path
branch
from
July 7, 2026 02:43
539102e to
a0f8fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than pulling out each sub-geometry .xy's coordinates, we can do one get_coordinates() call and fill in the codes all at once. Using cumsum to incrementally keep track of which ring we are in for the code placement.
I get about 50-100x speedup in the following example.