Adding 3 new API endpoints to make easy to get the list of catalogs#97
Open
erdoganfurkan wants to merge 2 commits into
Open
Adding 3 new API endpoints to make easy to get the list of catalogs#97erdoganfurkan wants to merge 2 commits into
erdoganfurkan wants to merge 2 commits into
Conversation
|
I think the error reported by MyPy, which is causing the tests to fail, is due to the fact that the type of "rooms" is not sufficiently specified. The following errors are reported: This occurs when iterating over the SQLAlchemy JSON column "user.rooms". Since Column is not iterable, MyPy rightfully raises an error-even though at runtime the field contains a list (from JSON). The fix (fix_type.patch) is to use SQLAlchemy 2.0's typing system with Mapped[...] and mapped_column(...), so that MyPy understands the actual Python type. I tested it on my side and all the tests seem to pass with this patch. What do you think, @jeandet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.