Skip to content

Conversation

@andreasnoack
Copy link
Contributor

Closes #2925 by wrapping the constant passed to ntuple in a Val

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@andreasnoack andreasnoack force-pushed the an/noallocsinrosenbrock branch from c9070a0 to 2d9ff3e Compare December 10, 2025 09:30
@andreasnoack
Copy link
Contributor Author

andreasnoack commented Dec 10, 2025

The Rosenbrock tests are failing on master, see https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/20029704426/job/57435465939, so it isn't easy to assess the impact of this PR. I ran the allocation tests for Rosenbrock locally and they pass with the fix here and they don't pass withouth the fix.

@ChrisRackauckas
Copy link
Member

Yes, I'll need to fix up tests in this repo before merging. Some of this is JET changes with v1.12 that I'll have to dig into and that's my plan for the week. So hold up a little bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uninferred variable in perform_step! for Rosenbrock

2 participants