This repository was archived by the owner on Apr 22, 2024. It is now read-only.
Partial matching of strings in generateScientificExpression #680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an additional
CONTAINS_STRING
condition to thegenerateScientificExpression
function to filter within strings in scientific metadata.Motivation
When defining our meta data schemas we realized that it would be very helpful for us to also filter on partially matching strings in the scientific metadata. However, so far there is only
EQUAL_TO_STRING
for text based entries in scientific metadata so we propose an additionalCONTAINS_STRING
which should work on simple strings as well as on lists. Here is an example:The idea of the proposed
CONTAINS_STRING
is that it would match e.g.John
in both cases (aslocalContact
as well as inexperimentalists
)Changes:
generateScientificExpression
inmongo-queryable.js
Tests included/Docs Updated?