Skip to content
This repository was archived by the owner on Jun 7, 2025. It is now read-only.

Conversation

@BillyPocketNC
Copy link

This may make installing for kicad harder.

I found the natsort library in pip, and changed the file to use it.
Would you like to include this change? I know it could make installing this project more difficult.

This is related to issue #156

This may make installing for kicad harder.
@set-soft
Copy link
Contributor

But this should be controlled by an option!

@BillyPocketNC
Copy link
Author

Thanks @set-soft. I will put this in my todo list.

@SchrodingersGat
Copy link
Owner

@BillyPocketNC long time to review on this one, sorry.

If you want to see this merged, please add the library requirement to setup.py (under install_requires section)

Also, please wrap in a try-catch so that it doesn't break for users who don't have natsort installed:

try:
    from natsort import natsorted
    groups = natsorted(groups, ...)
except ImportError:
    groups = sorted(...)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants