Change mscab extraction to use state handling, break into more helper methods#57
Merged
mnadareski merged 12 commits intoSabreTools:mainfrom Jan 25, 2026
Merged
Conversation
mnadareski
reviewed
Jan 25, 2026
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
SabreTools.Serialization/Wrappers/MicrosoftCabinet.Extraction.cs
Outdated
Show resolved
Hide resolved
mnadareski
approved these changes
Jan 25, 2026
HeroponRikiBestest
added a commit
to HeroponRikiBestest/SabreTools.Serialization
that referenced
this pull request
Jan 27, 2026
… methods (SabreTools#57) * Attempt 1 * Use private helper class * Remove comment * Add missing summaries * Don't use create pattern * Remove removed variable summary * Reduce what needs to be passed in * Further reduce what needs to be passed in * These didn't get tabbed for some reason * First round of fixes. * Second round of changes * Add a few comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fulfill the request to use proper state handling. Feedback needed.