Skip to content

Allow changing/editing PMP on messages - #1586

Merged
eleboucher merged 1 commit into
SableClient:devfrom
j0lol:edit-pmp-on-message
Aug 3, 2026
Merged

Allow changing/editing PMP on messages#1586
eleboucher merged 1 commit into
SableClient:devfrom
j0lol:edit-pmp-on-message

Conversation

@j0lol

@j0lol j0lol commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Description

Adds an option on messages to change the PMP

Part of #1279

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@j0lol

j0lol commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

PersonaPicker.tsx is quite messy from all of this, will try to refactor. Reviews welcome on how to make this all cleaner.

@j0lol
j0lol marked this pull request as draft August 2, 2026 18:56
Comment thread src/app/components/message/modals/Options.tsx Outdated
Comment thread src/app/components/message/modals/Options.tsx
Comment thread src/app/features/room/persona-picker/PersonaPicker.tsx Outdated
@j0lol
j0lol force-pushed the edit-pmp-on-message branch 3 times, most recently from 724de22 to 68687f1 Compare August 2, 2026 22:04
@j0lol

j0lol commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Currently noticed one bug: picking a room persona doesn't visually update correctly (button still works as normal.) But this was not introduced in this PR (I checked dev and saw the same bug, soo...)

Any reviews on that would be nice but not needed

@j0lol
j0lol marked this pull request as ready for review August 2, 2026 22:05
@j0lol
j0lol force-pushed the edit-pmp-on-message branch 2 times, most recently from 4a832ae to dc7c2f5 Compare August 2, 2026 23:02
Comment thread src/app/features/room/persona-picker/PersonaPicker.tsx
@j0lol
j0lol force-pushed the edit-pmp-on-message branch from dc7c2f5 to bf28707 Compare August 3, 2026 15:34
@eleboucher
eleboucher enabled auto-merge August 3, 2026 15:54
@eleboucher
eleboucher added this pull request to the merge queue Aug 3, 2026
Merged via the queue into SableClient:dev with commit 606b72b Aug 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants