Allow changing/editing PMP on messages - #1586
Merged
Merged
Conversation
Contributor
Author
|
|
j0lol
marked this pull request as draft
August 2, 2026 18:56
eleboucher
reviewed
Aug 2, 2026
eleboucher
reviewed
Aug 2, 2026
eleboucher
reviewed
Aug 2, 2026
j0lol
force-pushed
the
edit-pmp-on-message
branch
3 times, most recently
from
August 2, 2026 22:04
724de22 to
68687f1
Compare
Contributor
Author
|
Currently noticed one bug: picking a room persona doesn't visually update correctly (button still works as normal.) But this was not introduced in this PR (I checked dev and saw the same bug, soo...) Any reviews on that would be nice but not needed |
j0lol
marked this pull request as ready for review
August 2, 2026 22:05
j0lol
force-pushed
the
edit-pmp-on-message
branch
2 times, most recently
from
August 2, 2026 23:02
4a832ae to
dc7c2f5
Compare
eleboucher
requested changes
Aug 3, 2026
j0lol
force-pushed
the
edit-pmp-on-message
branch
from
August 3, 2026 15:34
dc7c2f5 to
bf28707
Compare
eleboucher
enabled auto-merge
August 3, 2026 15:54
eleboucher
approved these changes
Aug 3, 2026
37 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an option on messages to change the PMP
Part of #1279
Type of change
Checklist:
AI disclosure: