Skip to content

Add zypper search-packages plugin #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skazi0 merged 9 commits into from
Nov 30, 2021
Merged

Add zypper search-packages plugin #93

skazi0 merged 9 commits into from
Nov 30, 2021

Conversation

@skazi0
Copy link
Contributor

@skazi0 skazi0 commented Nov 16, 2021 •
edited
Loading

@skazi0 skazi0 force-pushed the package-search-plugin branch 3 times, most recently from 4992310 to 541026d Compare November 18, 2021 13:46
@skazi0 skazi0 changed the title Add CLI for zypper search-packages plugin Add zypper search-packages plugin Nov 18, 2021
@skazi0 skazi0 marked this pull request as ready for review November 18, 2021 13:47
@skazi0
Copy link
Contributor Author

skazi0 commented Nov 18, 2021 •
edited
Loading

NOTE: the "TEMP" commit is extracted to #95. It should be removed from here when that PR is merged.

@skazi0 skazi0 force-pushed the package-search-plugin branch 2 times, most recently from 93945cb to 58a420c Compare November 18, 2021 14:13
@skazi0
Add CLI for zypper search-packages plugin
b3beae9 
Added multi-call boilerplate and  CLI argument processing part of
search-packages plugin.
@skazi0
Update rpm spec for zypper-search-packages-plugin
a59090f
@skazi0
Add basic online package search
53dafa4 
Basic functionality includes xml and table output with different formats
for packages from API. No sorting or local package search included.
@skazi0
Add local repo search and duplicate removal
a057418
@skazi0
Add sorting and grouping options
42dddea
@skazi0 skazi0 force-pushed the package-search-plugin branch from 58a420c to 42dddea Compare November 18, 2021 20:24
@JanZerebecki JanZerebecki reopened this Nov 23, 2021
@JanZerebecki JanZerebecki reopened this Nov 23, 2021
@skazi0 skazi0 requested a review from djoreilly November 26, 2021 12:14
djoreilly
djoreilly reviewed Nov 29, 2021
View reviewed changes
Copy link
Contributor

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing the options from the man page, it seems -d and -g don't work the same as the ruby version.

@skazi0
Copy link
Contributor Author

skazi0 commented Nov 29, 2021

@djoreilly -d might be affected by this: jsrain/zypper-search-packages#6
I added -g which was missing.

@djoreilly
Copy link
Contributor

djoreilly commented Nov 29, 2021

@djoreilly -d might be affected by this: jsrain/zypper-search-packages#6 I added -g which was missing.

okay, does the -d need to be changed to -s in suseconnect/searchPackagesUsage.txt ?

@skazi0
Copy link
Contributor Author

skazi0 commented Nov 29, 2021 •
edited
Loading

okay, does the -d need to be changed to -s in suseconnect/searchPackagesUsage.txt ?

good catch! updated

djoreilly
djoreilly approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@skazi0 skazi0 merged commit 51e8a65 into SUSE:main Nov 30, 2021
@skazi0 skazi0 deleted the package-search-plugin branch November 30, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@djoreilly djoreilly djoreilly approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skazi0 @djoreilly @JanZerebecki