Skip to content

mkcloud: enable IPv6 #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mkcloud: enable IPv6 #3695

wants to merge 1 commit into from

Conversation

bmwiedemann
Copy link
Member

@bmwiedemann bmwiedemann commented Sep 17, 2019 •
edited
Loading

something unknown (maybe libvirt? - /usr/lib64/libvirt/connection-driver/libvirt_driver_network.so contains /proc/sys/net/ipv6/conf/%s/disable_ipv6 ) did set disable_ipv6=1 and that prevented ping6
from reaching crowbar

@bmwiedemann
mkcloud: enable IPv6
a3f7ca1 
something (likely libvirt) did set disable_ipv6=1 and that prevented ping6
from reaching crowbar
s-t-e-v-e-n-k
s-t-e-v-e-n-k approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was already a sysctl file added to cloudsalt to make sure it's enabled, but no objections.

nicolasbock
nicolasbock approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JanZerebecki
Copy link
Contributor

CI failure looks unrelated. Maybe a rebase would fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

+1 more reviewer

@nicolasbock nicolasbock nicolasbock approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bmwiedemann @JanZerebecki @nicolasbock @s-t-e-v-e-n-k