Skip to content

[Pass] Refinements of inter-core communication and auto-sync injection logic.#103

Open
xiaoyao-NKU wants to merge 4 commits intoSUNMMIO:tilelang_mesh_mainfrom
xiaoyao-NKU:feat/testing
Open

[Pass] Refinements of inter-core communication and auto-sync injection logic.#103
xiaoyao-NKU wants to merge 4 commits intoSUNMMIO:tilelang_mesh_mainfrom
xiaoyao-NKU:feat/testing

Conversation

@xiaoyao-NKU
Copy link
Copy Markdown
Collaborator

Improve barrier handling and redundant synchronization elimination logic; Support non-constant coreid in inter-core communication primitives.

…tion logic; Support non-constant coreid in inter-core communication primitives.
@JiaqiGuoSunlune JiaqiGuoSunlune self-requested a review April 21, 2026 06:18
@xiaoyao-NKU xiaoyao-NKU deleted the feat/testing branch April 22, 2026 03:10
@xiaoyao-NKU xiaoyao-NKU restored the feat/testing branch May 6, 2026 04:06
@xiaoyao-NKU xiaoyao-NKU reopened this May 6, 2026
@JiaqiGuoSunlune
Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review

if (!f->HasNonzeroAttr(tir::attr::kIsGlobalFunc)) {
return f;
}

P1 Badge Remove global-func gate that disables sync injection

The new early return on tir.is_global_func causes InjectSunmmioSync to become a no-op in the normal Sunmmio lowering pipeline: OptimizeForTarget invokes this pass at tilelang/engine/phase.py:240, while AnnotateEntryFunc (which sets entry/global function attrs) is only run later at tilelang/engine/phase.py:270. As a result, functions compiled through the default path often lack tir.is_global_func when this pass runs, so wait/barrier insertion is skipped entirely and asynchronous DMA/broadcast ordering is left unsynchronized.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants