Skip to content

Fix Cargo.lock mismatch causing deploy failure#61

Merged
hardyjosh merged 1 commit intomainfrom
fix/cargo-lock
Mar 5, 2026
Merged

Fix Cargo.lock mismatch causing deploy failure#61
hardyjosh merged 1 commit intomainfrom
fix/cargo-lock

Conversation

@findolor
Copy link
Collaborator

@findolor findolor commented Mar 5, 2026

Motivation

The deploy workflow has been failing since PR #58 was merged. The nix build runs cargo check --release --locked which rejects any mismatch between Cargo.lock and the actual dependency graph. The root cause is a stale tracing dependency listed under rain_orderbook_subgraph_client in Cargo.lock that doesn't exist in the submodule's crates/subgraph/Cargo.toml.

This was introduced during PR #58 development, where the local submodule had a dirty Cargo.toml (with tracing injected from a prior raindex-prelude run on an older submodule version). The regenerated Cargo.lock captured that phantom dependency. In CI, the submodule checks out clean, so --locked fails.

Solution

Remove the single stale tracing entry from rain_orderbook_subgraph_client's dependency list in Cargo.lock. Verified locally that cargo check --locked passes after this change with a cleanly initialized submodule.

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Remove stale tracing dep from rain_orderbook_subgraph_client that was
incorrectly added from a dirty submodule during PR #58.
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b9cdc23-5c93-4546-a094-c6492e1ce68a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/cargo-lock

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor changed the title Fix Cargo.lock for deploy Fix Cargo.lock mismatch causing deploy failure Mar 5, 2026
@findolor findolor self-assigned this Mar 5, 2026
@findolor findolor requested a review from hardyjosh March 5, 2026 19:29
@hardyjosh hardyjosh merged commit 076b695 into main Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants