Skip to content

KRB5: fix mem leak in authenticate_stored_users() #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexey-tikhonov wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −1
Open

KRB5: fix mem leak in authenticate_stored_users() #8517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b09f2fc
KRB5: fix mem leak in `authenticate_stored_users()`
alexey-tikhonov Mar 13, 2026
57137e1
UTIL: fix mem leak if `get_active_uid()` fails
alexey-tikhonov Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/providers/krb5/krb5_delayed_online_authentication.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ static errno_t authenticate_stored_users(
iter = new_hash_iter_context(deferred_auth_ctx->user_table);
if (iter == NULL) {
DEBUG(SSSDBG_CRIT_FAILURE, "new_hash_iter_context failed.\n");
hash_destroy(uid_table);
return EINVAL;
}

Expand Down Expand Up @@ -205,6 +206,7 @@ static errno_t authenticate_stored_users(
}

talloc_free(iter);
hash_destroy(uid_table);

return EOK;
}
Expand Down
8 changes: 7 additions & 1 deletion src/util/find_uid.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,13 @@ errno_t get_uid_table(TALLOC_CTX *mem_ctx, hash_table_t **table)
return ENOMEM;
}

return get_active_uid(*table, 0);
ret = get_active_uid(*table, 0);
if (ret != EOK) {
hash_destroy(*table);
*table = NULL;
}

return ret;
}

errno_t check_if_uid_is_active(uid_t uid, bool *result)
Expand Down
Loading