Skip to content

Add initial page about IdP support#95

Merged
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
sumit-bose:idp
Nov 14, 2025
Merged

Add initial page about IdP support#95
alexey-tikhonov merged 2 commits intoSSSD:masterfrom
sumit-bose:idp

Conversation

@sumit-bose
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @sumit-bose, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive documentation for SSSD's Identity Provider (IdP) support. It outlines how SSSD integrates with OAuth2.0/OIDC-based IdPs such as Keycloak and EntraID to facilitate user management and authentication at the system level. The changes include a dedicated introductory page with configuration examples and an update to the overall SSSD documentation structure to reflect this new capability.

Highlights

  • New IdP Documentation Page: An entirely new documentation page, idp-introduction.rst, has been added to detail SSSD's support for Identity Providers (IdPs), including concepts, supported providers like Keycloak and EntraID, and configuration examples.
  • Table of Contents Update: The main table of contents (contents.rst) has been updated to include a new section for 'Identity Providers (IdP)', making the new documentation easily discoverable.
  • Introduction Page Enhancement: The general introduction to SSSD (introduction.rst) has been modified to acknowledge the new IdP provider and includes a link to the sssd-idp(5) man page for further details.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces initial documentation for SSSD's Identity Provider (IdP) support, which is a valuable addition. The changes include a new introduction page, updates to the table of contents, and modifications to the main introduction to mention this new feature. My review focuses on improving the clarity, grammar, and correctness of the new documentation. I've pointed out several typos in the configuration examples which are critical to fix, as they would prevent users from successfully using them. Other suggestions aim to improve readability and consistency.

Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some parts are a little unclear. Have you looked at this with an RST viewer? github's processing is linking the entire page. It may just be an issue with github though.

@alexey-tikhonov alexey-tikhonov added the Changes requested Pull request requires changes label Nov 5, 2025
Copy link

@danlavu danlavu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I looked at all of Gemini's grammatical suggestions. They look correct, so I would make those changes as well.

@sumit-bose
Copy link
Contributor Author

Looks good, I looked at all of Gemini's grammatical suggestions. They look correct, so I would make those changes as well.

Hi,

all suggestions are included in the latest version.

bye,
Sumit

@alexey-tikhonov
Copy link
Member

Thank you, ACK.

@alexey-tikhonov alexey-tikhonov added Waiting for review Pull request is awaiting review and removed Changes requested Pull request requires changes labels Nov 14, 2025
@alexey-tikhonov alexey-tikhonov merged commit c8cd0fc into SSSD:master Nov 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for review Pull request is awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants