Skip to content

Disabling AD CA until containers ready#238

Merged
danlavu merged 1 commit intoSSSD:masterfrom
spoore1:disable_adca
Mar 12, 2026
Merged

Disabling AD CA until containers ready#238
danlavu merged 1 commit intoSSSD:masterfrom
spoore1:disable_adca

Conversation

@spoore1
Copy link
Contributor

@spoore1 spoore1 commented Mar 12, 2026

The AD CA functionality will cause failures in initializing the AD role until the sssd-ci-containers ansible role for AD is updated to configure the system properly for CA functionality.

For now, commenting out the CA initializzation from the AD Role.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily disables the Active Directory Certificate Authority (AD CA) initialization and its associated property within the ad.py role. This change is implemented to prevent failures during the initialization of the AD role, as the sssd-ci-containers ansible role currently lacks the necessary configuration for proper CA functionality.

Highlights

  • AD CA Functionality: Temporarily disabled the Active Directory Certificate Authority (AD CA) functionality within the ad.py role by commenting out its initialization and property.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • sssd_test_framework/roles/ad.py
    • Commented out the initialization of the _ca attribute.
    • Commented out the ca property and its docstring.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the AD Certificate Authority functionality by commenting out the related code. While this works, a more robust approach for temporarily disabling a feature is to raise a NotImplementedError when it's accessed. This provides a clearer error message and serves as a better reminder for future re-enabling. I've provided suggestions to implement this cleaner approach.

The AD CA functionality will cause failures in initializing the AD role
until the sssd-ci-containers ansible role for AD is updated to configure
the system properly for CA functionality.

For now, commenting out the CA initializzation from the AD Role.
@spoore1 spoore1 requested a review from danlavu March 12, 2026 20:12
@danlavu danlavu merged commit 8a9e9d9 into SSSD:master Mar 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants