Skip to content

dns: Add a dns server for redhat domain in idmci#170

Merged
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
jakub-vavra-cz:dns
Mar 25, 2026
Merged

dns: Add a dns server for redhat domain in idmci#170
jakub-vavra-cz merged 1 commit intoSSSD:masterfrom
jakub-vavra-cz:dns

Conversation

@jakub-vavra-cz
Copy link
Contributor

Dnsmasq seems to have an issue with upstream dns servers in aws. This adds a fixed upstream server for redhat domain.

Dnsmasq seems to have an issue with upstream dns servers in aws.
This adds a fixed upstream server for redhat domain.
@jakub-vavra-cz jakub-vavra-cz added Waiting for review Trivial A single reviewer is sufficient to review the Pull Request labels Mar 24, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a dnsmasq issue within the idmci environment on AWS, where it struggled with upstream DNS resolution. It introduces a dedicated upstream DNS server for the redhat.com domain, ensuring reliable name resolution for Red Hat-related services.

Highlights

  • DNS Configuration: Added a specific upstream DNS server (10.11.5.19) for the redhat.com domain to the dnsmasq configuration template.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jakub-vavra-cz jakub-vavra-cz requested a review from danlavu March 24, 2026 16:12
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the etc.dnsmasq.conf.j2 template to include a specific DNS server for redhat.com. The feedback suggests that the hardcoded IP address for this server should be replaced with an Ansible variable to enhance maintainability and adaptability across different environments.

@jakub-vavra-cz jakub-vavra-cz merged commit 68e054b into SSSD:master Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trivial A single reviewer is sufficient to review the Pull Request Waiting for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants