Skip to content

Some Koopa functions#1865

Draft
SushiInYourFace wants to merge 7 commits intoSMGCommunity:masterfrom
SushiInYourFace:koopa
Draft

Some Koopa functions#1865
SushiInYourFace wants to merge 7 commits intoSMGCommunity:masterfrom
SushiInYourFace:koopa

Conversation

@SushiInYourFace
Copy link
Contributor

No description provided.

@decomp-dev
Copy link

decomp-dev bot commented Jan 26, 2026

Report for RMGK01 (221bb4e - 33f66cb)

📈 Matched code: 40.62% (+0.03%, +1512 bytes)
📈 Matched data: 19.83% (+0.01%, +200 bytes)

✅ 28 new matches
Unit Item Bytes Before After
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::exeWaitDemo() +332 0.00% 100.00%
main/Game/Boss/KoopaPlanetShadow .data +160 0.00% 100.00%
main/Game/Boss/KoopaPlanetShadow KoopaPlanetShadow::init(const JMapInfoIter&) +116 0.00% 100.00%
main/Game/Boss/KoopaSequencer KoopaSequencer::KoopaSequencer(const char*, long) +108 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::kill() +96 0.00% 100.00%
main/Game/Boss/KoopaPlanetShadow KoopaPlanetShadow::~KoopaPlanetShadow() +92 0.00% 100.00%
main/Game/Boss/KoopaPlanetShadow KoopaPlanetShadow::KoopaPlanetShadow(const Koopa*) +92 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::~KoopaDemoPowerUp() +88 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::init() +88 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::~KoopaDemoJumpToPlanet() +88 0.00% 100.00%
main/Game/Boss/KoopaSequencer KoopaSequencer::~KoopaSequencer() +88 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::KoopaDemoPowerUp(Koopa*) +84 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::KoopaDemoJumpToPlanet(Koopa*) +84 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp __sinit_\KoopaDemoPowerUp_cpp +44 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp .sdata2 +16 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::appear() +16 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp NrvKoopaDemoPowerUp::KoopaDemoPowerUpNrvWaitDemo::KoopaDemoPowerUpNrvWaitDemo() +16 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp NrvKoopaDemoPowerUp::KoopaDemoPowerUpNrvDemo::KoopaDemoPowerUpNrvDemo() +16 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet NrvKoopaDemoJumpToPlanet::KoopaDemoJumpToPlanetNrvStart::KoopaDemoJumpToPlanetNrvStart() +16 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet NrvKoopaDemoJumpToPlanet::KoopaDemoJumpToPlanetNrvFall::KoopaDemoJumpToPlanetNrvFall() +16 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp .sbss +8 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp NrvKoopaDemoPowerUp::KoopaDemoPowerUpNrvDemo::execute(Spine*) const +8 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp NrvKoopaDemoPowerUp::KoopaDemoPowerUpNrvWaitDemo::execute(Spine*) const +8 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::startReady() +8 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet NrvKoopaDemoJumpToPlanet::KoopaDemoJumpToPlanetNrvStart::execute(Spine*) const +8 0.00% 100.00%
main/Game/Boss/KoopaPlanetShadow .sdata2 +8 0.00% 100.00%
main/Game/Boss/KoopaDemoPowerUp .ctors +4 0.00% 100.00%
main/Game/Boss/KoopaDemoJumpToPlanet .ctors +4 0.00% 100.00%
📈 13 improvements in unmatched functions
Unit Item Bytes Before After
main/Game/Boss/KoopaDemoPowerUp KoopaDemoPowerUp::exeDemo() +367 0.00% 99.93%
main/Game/Boss/KoopaPlanetShadow KoopaPlanetShadow::calcAndSetBaseMtx() +198 0.00% 93.77%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::exeStart() +131 0.00% 99.73%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::kill() +123 0.00% 99.90%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::init() +103 0.00% 99.88%
main/Game/Boss/KoopaSequencer KoopaSequencer::init(Koopa*, const JMapInfoIter&) +74 0.00% 56.12%
main/Game/Boss/KoopaDemoPowerUp .data +63 0.00% 17.98%
main/Game/Boss/KoopaDemoJumpToPlanet .data +55 0.00% 12.29%
main/Game/Boss/KoopaDemoJumpToPlanet __sinit_\KoopaDemoJumpToPlanet_cpp +44 0.00% 73.33%
main/Game/Boss/KoopaSequencer .data +17 0.00% 30.61%
main/Game/Boss/KoopaDemoJumpToPlanet .sbss +10 0.00% 66.67%
main/Game/Boss/KoopaDemoJumpToPlanet KoopaDemoJumpToPlanet::exeFall() +3 0.00% 1.47%
main/Game/Boss/KoopaDemoJumpToPlanet NrvKoopaDemoJumpToPlanet::KoopaDemoJumpToPlanetNrvFall::execute(Spine*) const +1 0.00% 20.00%

Copy link
Collaborator

@ThatNintendoNerd ThatNintendoNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run clang-format on your changes.

void exeDemo();

/* 0x8 */ bool _8;
/* 0C */ Koopa* mParent;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the x in 0x.

@@ -0,0 +1,18 @@
#pragma once

#include "Game/Boss/Koopa.hpp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer forward declaration for types referred to by pointer or reference in header files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants