Skip to content

Highlights#30

Open
Jasspie wants to merge 9 commits intoalt-themingfrom
highlights
Open

Highlights#30
Jasspie wants to merge 9 commits intoalt-themingfrom
highlights

Conversation

@Jasspie
Copy link
Collaborator

@Jasspie Jasspie commented Jul 11, 2021

  • added highlighting under text,
  • use "~" in the constants file for highlights to appear
  • updated how the render() function works
  • added invertHighlightColor

@vercel
Copy link

vercel bot commented Jul 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/set-hacks-dev/set-hacks/8UKvwcADo2XUH4sY4mQTjhmwsnbZ
✅ Preview: https://set-hacks-git-highlights-set-hacks-dev.vercel.app

@Jasspie Jasspie linked an issue Jul 11, 2021 that may be closed by this pull request
700: "#282a87",
800: "#221c48",
900: "#24185d",
1000: "#ffd498",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really a big deal but perhaps we should move the 1000 and 1100 out of the brand colours and name it highlightYellow or smt (I think we should try to keep brand colours as just shade of purples)

return theme;
};

export const invertHighlightColor = (T) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we combine the invertHighlightColor and the invertAccentColor into the same theme? I feel like since they'd both be dark mode we can just have one theme for that - idk do y'all have any thoughts on that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could have an invertTheme or darkMode function that calls the two functions? i don't know if that'd be cleaner or messier, but it gives us the option to only apply certain inversions if we want to without having to rewrite stuff

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea I think this would be a good idea especially if there's any other dark theme stuff that comes up later on

Copy link
Collaborator

@gracewgao gracewgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small nitpicky comments but the highlighting looks super cool! I think we can merge this and prob refactor code later (in all parts of the website) if needed

@gracewgao
Copy link
Collaborator

tweaked some of the highlighted words in the headers to focus more on the "important" words - I think it's best to highlight less words for better legibility and higher impact on the words that are highlighted (but feel free to change the highlighted words to smt else if you'd like)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add highlight under text

3 participants