Conversation
Jasspie
commented
Jul 11, 2021
- added highlighting under text,
- use "~" in the constants file for highlights to appear
- updated how the render() function works
- added invertHighlightColor
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/set-hacks-dev/set-hacks/8UKvwcADo2XUH4sY4mQTjhmwsnbZ |
Theming and stars
| 700: "#282a87", | ||
| 800: "#221c48", | ||
| 900: "#24185d", | ||
| 1000: "#ffd498", |
There was a problem hiding this comment.
not really a big deal but perhaps we should move the 1000 and 1100 out of the brand colours and name it highlightYellow or smt (I think we should try to keep brand colours as just shade of purples)
| return theme; | ||
| }; | ||
|
|
||
| export const invertHighlightColor = (T) => { |
There was a problem hiding this comment.
should we combine the invertHighlightColor and the invertAccentColor into the same theme? I feel like since they'd both be dark mode we can just have one theme for that - idk do y'all have any thoughts on that
There was a problem hiding this comment.
maybe we could have an invertTheme or darkMode function that calls the two functions? i don't know if that'd be cleaner or messier, but it gives us the option to only apply certain inversions if we want to without having to rewrite stuff
There was a problem hiding this comment.
yea I think this would be a good idea especially if there's any other dark theme stuff that comes up later on
|
tweaked some of the highlighted words in the headers to focus more on the "important" words - I think it's best to highlight less words for better legibility and higher impact on the words that are highlighted (but feel free to change the highlighted words to smt else if you'd like) |