FizzBuzz-Redux__W5-A4 Hollis (final)

[hollislau]

Remove all DOM related content from the code and refactor into a CommonJS module pattern to publish the FizzBuzz app as an npm package.

[miketierney]

Rather than simply pushing your values in to your _stringsArray, when your constructor is run you might want to also reset your _stringsArray; the current implementation actually keeps it from allowing different instances to have different output. Currently, this is what's happening:

var FizzBuzz = require("sea-d44-fizz-buzz-hl");
var buzz1 = new FizzBuzz();
buzz1.input(1,10);
console.log(buzz1.output()); // >> [1,2,"fizz",4,"buzz",...]

var buzz2 = new FizzBuzz("tick", "tock");
buzz2.input(1,100);
console.log(buzz2.output()); // >> [1,2,"fizz",4,"buzz"...]

Basically, with these private variables, you're sharing your data between the instances (which can be useful in some cases). It might make more sense to store the _stringsArray as a property of the instance: this.stringsArray instead:

var FizzBuzz = function(string1, string2) {
  this.stringsArray = [string1, string2];
};

[miketierney]

Looks pretty good; the only real issue is with the instance "pollution" for the string values. 14/15.