Skip to content

fix(ui5-side-navigation): focus is correct after selecting overflow item #11702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2025
Merged

fix(ui5-side-navigation): focus is correct after selecting overflow item #11702

merged 9 commits into from
Jun 19, 2025

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Jun 10, 2025 •
edited
Loading

Focus returns to the selected navigation item when the overflow menu is closed.

fixes #11511

@TeodorTaushanov TeodorTaushanov requested review from Stoev and a team June 16, 2025 11:25
Stoev
Stoev reviewed Jun 16, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider:

fix(ui5-side-navigation): focus is correct after selecting overflow item

Is additional explanation necessary, for example:
Focus returns to the selected navigation item when the overflow menu is closed.

@TeodorTaushanov TeodorTaushanov changed the title fix(ui5-side-navigation): fix focus after the menu is closed fix(ui5-side-navigation): focus is correct after selecting overflow item Jun 16, 2025
@TeodorTaushanov
Copy link
Member Author

Please consider:

fix(ui5-side-navigation): focus is correct after selecting overflow item

Is additional explanation necessary, for example: Focus returns to the selected navigation item when the overflow menu is closed.

Done.

@TeodorTaushanov TeodorTaushanov requested a review from Stoev June 16, 2025 12:43
Stoev
Stoev reviewed Jun 16, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

LidiyaGeorgieva
LidiyaGeorgieva requested changes Jun 17, 2025
View reviewed changes
@TeodorTaushanov TeodorTaushanov merged commit bb22451 into main Jun 19, 2025
19 of 20 checks passed
@TeodorTaushanov TeodorTaushanov deleted the sidenav_focus branch June 19, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Side Navigation]: focus is lost after selecting overflow item
3 participants
@TeodorTaushanov @LidiyaGeorgieva @Stoev