Skip to content

fix(popups): fix finding correct focusable element #11700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

fix(popups): fix finding correct focusable element #11700

merged 2 commits into from
Jun 17, 2025

Conversation

TeodorTaushanov
Copy link
Member

@TeodorTaushanov TeodorTaushanov commented Jun 10, 2025 •
edited
Loading

The problem occurs when opening a dialog with a toolbar in the footer; pressing Shift + TAB causes focus to escape the dialog, instead of remaining contained.

fixes #11606

@TeodorTaushanov TeodorTaushanov requested review from Stoev and a team June 10, 2025 12:03
@Stoev
Copy link

Stoev commented Jun 10, 2025

The problem can be seen when a dialog featuring a toolbar in the footer is opened, as pressing Shift + TAB causes the focus to move outside of the dialog.

Eventually can be rephrased:

The problem occurs when opening a dialog with a toolbar in the footer; pressing Shift + TAB causes focus to escape the dialog, instead of remaining contained.

Otherwise looks good.

Stoev
Stoev reviewed Jun 10, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tentative comment, otherwise is good.

@TeodorTaushanov
Copy link
Member Author

The problem can be seen when a dialog featuring a toolbar in the footer is opened, as pressing Shift + TAB causes the focus to move outside of the dialog.

Eventually can be rephrased:

The problem occurs when opening a dialog with a toolbar in the footer; pressing Shift + TAB causes focus to escape the dialog, instead of remaining contained.

Otherwise looks good.

Done.

@TeodorTaushanov TeodorTaushanov requested a review from Stoev June 11, 2025 06:07
Stoev
Stoev reviewed Jun 12, 2025
View reviewed changes
Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@TeodorTaushanov TeodorTaushanov merged commit 972fddf into main Jun 17, 2025
12 checks passed
@TeodorTaushanov TeodorTaushanov deleted the dialog_shift_tab branch June 17, 2025 15:41
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.12.0-rc.1 🎉

The release is available on v2.12.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stoev Stoev Stoev left review comments

@LidiyaGeorgieva LidiyaGeorgieva LidiyaGeorgieva approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-dialog]: allows focus to leave the modal and navigate to other part of the page
4 participants
@TeodorTaushanov @Stoev @ui5-webcomponents-bot @LidiyaGeorgieva