Skip to content

chore: change playground splitter #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

chore: change playground splitter #11670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d2f26d
chore: change playground splitter
nnaydenow Jun 5, 2025
17b20d3
fix: on mobile
nnaydenow Jun 5, 2025
fe021cc
chore: fix touch on mobile
nnaydenow Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions packages/website/src/components/Editor/Splitter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import React, { useState, useRef, useEffect } from 'react';

export default function Splitter({ preview, editor }) {
const [moving, setMoving] = useState(false);
const [leftColumnSize, setLeftColumnSize] = useState("calc(50% - 0.5rem)");
const [rightColumnSize, setRightColumnSize] = useState("calc(50% - 0.5rem)");
const containerRef = useRef();

useEffect(() => {
const handleMouseMove = (e) => {
if (!moving) return;

const containerRect = containerRef.current.getBoundingClientRect();
const clientX = e.touches?.length > 0 ? e.touches[0].clientX : e.clientX;
const offsetX = clientX - containerRect.left;

const leftPercent = Math.round((offsetX / containerRect.width) * 100);
const rightPercent = 100 - leftPercent;

console.log(leftPercent, rightPercent)

setLeftColumnSize(`calc(${leftPercent}% - 0.5rem)`);
setRightColumnSize(`calc(${rightPercent}% - 0.5rem)`);
};

const handleMouseUp = () => {
setMoving(false);
};

if (moving) {
document.addEventListener("mousemove", handleMouseMove);
document.addEventListener("mouseup", handleMouseUp);
document.addEventListener("touchmove", handleMouseMove);
document.addEventListener("touchend", handleMouseUp);
}

return () => {
document.removeEventListener("mousemove", handleMouseMove);
document.removeEventListener("mouseup", handleMouseUp);
document.removeEventListener("touchmove", handleMouseMove);
document.removeEventListener("touchend", handleMouseUp);
};
}, [moving]);

const mousedownHandler = () => {
setMoving(true);
};

return (
<>
{moving && (
<div
style={{
position: 'fixed',
inset: 0,
zIndex: 9999,
cursor: 'col-resize',
}}
/>
)}
<div style={{ display: "flex", height: "90vh", minHeight: "600px" }} ref={containerRef}>
<div style={{ width: leftColumnSize, minWidth: "10%", transition: "width 0.15s linear" }}>{preview}</div>
<div
style={{
width: "1rem",
backgroundColor: "gainsboro",
display: "flex",
alignItems: "center",
flexShrink: 0,
userSelect: "none",
touchAction: "none",
cursor: "col-resize"
}}
onMouseDown={mousedownHandler}
onTouchStart={mousedownHandler}
>
<svg viewBox="0 0 512 512" preserveAspectRatio="xMidYMid meet" xmlns="http://www.w3.org/2000/svg">
<g role="presentation">
<path d="M176 0q20 0 34 14t14 34-14 34-34 14-34-14-14-34 14-34 34-14zm160 96q-20 0-34-14t-14-34 14-34 34-14 34 14 14 34-14 34-34 14zm-160 42q20 0 34 14t14 34-14 34-34 14-34-14-14-34 14-34 34-14zm160 0q20 0 34 14t14 34-14 34-34 14-34-14-14-34 14-34 34-14zM176 278q20 0 34 14t14 34q0 19-14.5 33.5T176 374t-33.5-14.5T128 326q0-20 14-34t34-14zm160 0q20 0 34 14t14 34q0 19-14.5 33.5T336 374t-33.5-14.5T288 326q0-20 14-34t34-14zM176 416q20 0 34 14t14 34-14 34-34 14-34-14-14-34 14-34 34-14zm160 0q20 0 34 14t14 34-14 34-34 14-34-14-14-34 14-34 34-14z"></path>
</g>
</svg>
</div>
<div style={{ width: rightColumnSize, minWidth: "10%", transition: "width 0.15s linear" }}>{editor}</div>
</div>
</>
);
}
173 changes: 85 additions & 88 deletions packages/website/src/components/Editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { ThemeContext, ContentDensityContext, TextDirectionContext } from "@site
import { encodeToBase64, decodeFromBase64 } from "./share.js";
import clsx from "clsx";
import ShareIcon from "@ui5/webcomponents-icons/dist/v5/share-2.svg";
import { Splitter } from 'react-splitter-light';
import Splitter from './Splitter.js';
import DownloadIcon from "@ui5/webcomponents-icons/dist/v5/download-from-cloud.svg";
import EditIcon from "@ui5/webcomponents-icons/dist/v5/edit.svg";
import ActionIcon from "@ui5/webcomponents-icons/dist/v5/action.svg";
Expand Down Expand Up @@ -40,10 +40,10 @@ const getProjectFromPool = () => {

// return a project element to the pool for reuse
const returnProjectToPool = (project) => {
projectPool.push(project);
projectPool.push(project);
}

export default function Editor({html, js, css, mainFile = "main.js", canShare = false, standalone = false, mainFileSelected = false }) {
export default function Editor({ html, js, css, mainFile = "main.js", canShare = false, standalone = false, mainFileSelected = false }) {
const projectContainerRef = useRef(null);
const projectRef = useRef(null);
const previewRef = useRef(null);
Expand All @@ -54,12 +54,12 @@ export default function Editor({html, js, css, mainFile = "main.js", canShare =
// name is set on iframe so it can be passed back in resize message to identify which iframe is resized
const iframeId = useId();
const [editorVisible, setEditorVisible] = useState(false);
const {siteConfig, siteMetadata} = useDocusaurusContext();
const { siteConfig, siteMetadata } = useDocusaurusContext();
const { theme, setTheme } = useContext(ThemeContext);
const { contentDensity, setContentDensity } = useContext(ContentDensityContext);
const { textDirection, setTextDirection } = useContext(TextDirectionContext);
const [copied, setCopied] = useState(false);
const [ activeExample, setActiveExample ] = useState("");
const [activeExample, setActiveExample] = useState("");

function calcImports() {
if (process.env.NODE_ENV === 'development' || siteConfig.customFields.ui5DeploymentType === "nightly") {
Expand Down Expand Up @@ -240,7 +240,7 @@ export default function Editor({html, js, css, mainFile = "main.js", canShare =
content: addHeadContent(fixAssetPaths(_html)),
},
"playground-support.js": {
content: playgroundSupport({theme, textDirection, contentDensity, iframeId}),
content: playgroundSupport({ theme, textDirection, contentDensity, iframeId }),
hidden: true,
},
[mainFile]: {
Expand Down Expand Up @@ -275,7 +275,7 @@ ${fixAssetPaths(_js)}`,
// if the saved project has a main from an old default, and the default project has a main.tsx file, restore the saved one
delete newConfig.files["main.tsx"];
}
newConfig.files = {...newConfig.files, ...savedConfig};
newConfig.files = { ...newConfig.files, ...savedConfig };
} catch (e) {
console.log(e);
}
Expand All @@ -289,10 +289,10 @@ ${fixAssetPaths(_js)}`,
sharedConfig["index.html"].content = addHeadContent(fixAssetPaths(sharedConfig["index.html"].content));
const oldMainFile = sharedConfig["main.js"] || sharedConfig["main.ts"];
if (oldMainFile && newConfig.files["main.tsx"]) {
// if the shared project has a main from an old default, and the default project has a main.tsx file, restore the saved one
// if the shared project has a main from an old default, and the default project has a main.tsx file, restore the saved one
delete newConfig.files["main.tsx"];
}
newConfig.files = {...newConfig.files, ...sharedConfig};
newConfig.files = { ...newConfig.files, ...sharedConfig };
} catch (e) {
console.log(e);
}
Expand All @@ -316,10 +316,10 @@ ${fixAssetPaths(_js)}`,

// algolia search opens the search on key `/` because this custom element is the event target but has no `isContentEditable`
Object.defineProperty(fileEditorRef.current, "isContentEditable", {
configurable: true,
get() {
return true;
},
configurable: true,
get() {
return true;
},
});

tabBarRef.current.editor = fileEditorRef.current;
Expand Down Expand Up @@ -347,7 +347,7 @@ ${fixAssetPaths(_js)}`,
// setting has changed but exising project config is there
// update the playground-support.js only with the new settings so refresh works correctly
const newConfig = JSON.parse(JSON.stringify(projectRef.current.config));
newConfig.files["playground-support.js"].content = playgroundSupport({theme, textDirection, contentDensity, iframeId});
newConfig.files["playground-support.js"].content = playgroundSupport({ theme, textDirection, contentDensity, iframeId });
projectRef.current.config = newConfig;
}, [theme, contentDensity, textDirection]);

Expand All @@ -362,19 +362,16 @@ ${fixAssetPaths(_js)}`,
function optionalSplitter(editor, preview) {
return (
<>
{ standalone
{standalone
?
<div style={{width: "100%"}}>
<Splitter>
{preview}
{editor}
</Splitter>
</div>
<div>
<Splitter preview={preview} editor={editor}></Splitter>
</div>
:
<div>
{editor}
{preview}
</div>
<div>
{editor}
{preview}
</div>
}
</>
)
Expand All @@ -384,10 +381,10 @@ ${fixAssetPaths(_js)}`,
return (
<>
<playground-preview class={clsx(styles.previewResultHidden, {
[styles['preview-standalone']]: standalone,
[styles['preview-sample']]: !standalone,
})}
style={standalone ? undefined: { height: "unset", minHeight: "7rem" }} ref={previewRef}
[styles['preview-standalone']]: standalone,
[styles['preview-sample']]: !standalone,
})}
style={standalone ? undefined : { height: "unset", minHeight: "7rem" }} ref={previewRef}
></playground-preview>
</>
)
Expand All @@ -401,7 +398,7 @@ ${fixAssetPaths(_js)}`,
[styles['editor-standalone']]: standalone,
[styles['editor-sample']]: !standalone,
})}
style={{display: editorVisible | standalone ? "block" : "none"}}>
style={{ display: editorVisible | standalone ? "block" : "none" }}>
<playground-tab-bar editable-file-system ref={tabBarRef}></playground-tab-bar>
<playground-file-editor line-numbers ref={fileEditorRef}></playground-file-editor>
</div>
Expand Down Expand Up @@ -436,37 +433,37 @@ ${fixAssetPaths(_js)}`,

{canShare
?
<>
<div className={`${styles.editor__toolbar}`}>
<ExamplesMenu loadHelloWorld={loadHelloWorld} loadCounter={loadCounter} initialActiveState={getExampleMenuInitialState()}/>
<div>
<button
className={`button button--secondary ${styles.previewResult__download}`}
onClick={ download }
>
<DownloadIcon className={`${styles.btn__icon}`}/>
Download
{ copied
? <div style={ {position: "absolute"} }>
<span className={styles["copy-status"]}>&#x2714; Link copied</span>
</div>
<>
<div className={`${styles.editor__toolbar}`}>
<ExamplesMenu loadHelloWorld={loadHelloWorld} loadCounter={loadCounter} initialActiveState={getExampleMenuInitialState()} />
<div>
<button
className={`button button--secondary ${styles.previewResult__download}`}
onClick={download}
>
<DownloadIcon className={`${styles.btn__icon}`} />
Download
{copied
? <div style={{ position: "absolute" }}>
<span className={styles["copy-status"]}>&#x2714; Link copied</span>
</div>
: <></>
}
</button>

<button
className={`button button--secondary ${styles.previewResult__share}`}
onClick={ share }
>
<ShareIcon className={`${styles.btn__icon}`}/>
Share
</button>

</div>
}
</button>

<button
className={`button button--secondary ${styles.previewResult__share}`}
onClick={share}
>
<ShareIcon className={`${styles.btn__icon}`} />
Share
</button>

</div>
</>
</div>
</>
:
<></>
<></>
}

<div
Expand All @@ -477,37 +474,37 @@ ${fixAssetPaths(_js)}`,
style={{ border: "1px solid hsla(203, 50%, 30%, 0.15)", boxShadow: "var(--ifm-color-secondary) 0 0 3px 0", borderRadius: "0.5rem", overflow: "hidden" }}
>
{optionalSplitter(preview(), editor())}
<div className={ `${styles.previewResult__actions} ${(canShare ? styles.previewResult__hasShare : "")} `}>
{ standalone
?
<div className={`${styles.previewResult__actions} ${(canShare ? styles.previewResult__hasShare : "")} `}>
{standalone
?
<></>
:
<>
<button
className={`button button--secondary ${styles.previewResult__downloadSample}`}
onClick={ download }
>
<DownloadIcon className={`${styles["btn__icon--edit"]} `}/>
Download
</button>

<button
className={`button button--secondary ${styles.previewResult__downloadSample}`}
onClick={ openInNewTab }
>
<ActionIcon className={`${styles["btn__icon--edit"]} `}/>
Open in Playground
</button>

<button
className={`button ${(editorVisible ? "button--secondary" : "button--secondary")} ${styles.previewResult__toggleCodeEditor} ${(canShare ? styles.previewResult__hasShare : "")}` }
onClick={ toggleEditor }
>
{editorVisible ? <HideIcon className={`${styles["btn__icon--edit"]} `}/> : <EditIcon className={`${styles["btn__icon--edit"]}`}/>}
{editorVisible ? "Hide code" : "Edit"}
</button>
</>
}
:
<>
<button
className={`button button--secondary ${styles.previewResult__downloadSample}`}
onClick={download}
>
<DownloadIcon className={`${styles["btn__icon--edit"]} `} />
Download
</button>

<button
className={`button button--secondary ${styles.previewResult__downloadSample}`}
onClick={openInNewTab}
>
<ActionIcon className={`${styles["btn__icon--edit"]} `} />
Open in Playground
</button>

<button
className={`button ${(editorVisible ? "button--secondary" : "button--secondary")} ${styles.previewResult__toggleCodeEditor} ${(canShare ? styles.previewResult__hasShare : "")}`}
onClick={toggleEditor}
>
{editorVisible ? <HideIcon className={`${styles["btn__icon--edit"]} `} /> : <EditIcon className={`${styles["btn__icon--edit"]}`} />}
{editorVisible ? "Hide code" : "Edit"}
</button>
</>
}
</div>

</div>
Expand Down
7 changes: 0 additions & 7 deletions packages/website/src/components/Editor/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,6 @@
z-index: 1;
}

.container-standalone {
display: flex;
flex-direction: row-reverse;
width: 100%;
height: 100vh;
}

.container-standalone playground-file-editor {
height: 100%;
}
Expand Down
Loading