Skip to content

feat: ui5 language assistant logo #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

feat: ui5 language assistant logo #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
36dd0b7
feat: ui5 language assistant logo
johannes-kolbe Jun 13, 2025
62809e0
chore: changeset
johannes-kolbe Jun 13, 2025
0d8372a
fix: ui5 version
marufrasully Jun 18, 2025
c6015ba
fix: change set
marufrasully Jun 18, 2025
14df9ca
fix: failing test
marufrasully Jun 20, 2025
3f27451
fix: add change set
marufrasully Jun 20, 2025
81a0923
fix: update to `sonarcube-scan-action` in release.yaml
johannes-kolbe Jun 23, 2025
7e547c1
fix: version typo `sonarcube-scan-action`
johannes-kolbe Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-shrimps-give.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ui5-language-assistant/context": patch
---

feat: new logo
5 changes: 5 additions & 0 deletions .changeset/eleven-yaks-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"vscode-ui5-language-assistant": patch
---

feat: new logo
7 changes: 7 additions & 0 deletions .changeset/quick-jobs-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@ui5-language-assistant/test-utils": patch
"@ui5-language-assistant/constant": patch
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
---

feat: new logo
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- name: Run SonarCloud scan
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '14.x'
uses: sonarsource/sonarcloud-github-action@master
uses: SonarSource/sonarqube-scan-action@v5.2.0
env:
GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions packages/constant/src/constant.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ export const OPEN_FRAMEWORK = "OpenUI5";
export const DEFAULT_UI5_FRAMEWORK = "SAPUI5";

//https://ui5.sap.com/version.json
export const DEFAULT_UI5_VERSION = "1.71.73";
export const DEFAULT_UI5_VERSION = "1.71.75";
// https://sdk.openui5.org/version.json
export const DEFAULT_OPEN_UI5_VERSION = "1.71.69";
export const DEFAULT_OPEN_UI5_VERSION = "1.71.71";

export const DEFAULT_UI5_VERSION_BASE = "1.71";

Expand Down
6 changes: 3 additions & 3 deletions packages/context/test/unit/ui5-model.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,10 +578,10 @@ describe("the UI5 language assistant ui5 model", () => {
expected: () => getExpectedVersion("SAPUI5", "1.104"),
},
{
// supported version
version: () => Object.keys(currentVersionMaps.SAPUI5)[1],
// supported version - take second entry which is supported version (now it ias latest and active entry)
version: () => Object.keys(currentVersionMaps.SAPUI5)[2],
expected: () =>
currentVersionMaps.SAPUI5[Object.keys(currentVersionMaps.SAPUI5)[1]]
currentVersionMaps.SAPUI5[Object.keys(currentVersionMaps.SAPUI5)[2]]
.version,
},
{
Expand Down
Binary file modified packages/vscode-ui5-language-assistant/resources/ui5-language-assistant.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
32 changes: 0 additions & 32 deletions packages/vscode-ui5-language-assistant/resources/ui5-language-assistant.svg
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test-packages/test-utils/src/utils/semantic-model-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const MODEL_CACHE: Record<TestModelVersion, UI5SemanticModel> =
Object.create(null);

const fixes: Record<TestModelVersion, TypeNameFix> = {
"1.71.73": {
"1.71.75": {
array: "any[]",
Array: "any[]",
bloolean: undefined,
Expand Down Expand Up @@ -258,7 +258,7 @@ type LibraryFix = (content: Json) => void;

// Library version -> library name -> fix function
const libraryFixes: Record<TestModelVersion, Record<string, LibraryFix[]>> = {
"1.71.73": {},
"1.71.75": {},
"1.84.51": {},
"1.96.27": {
"sap.ui.mdc": [
Expand Down
Loading