fix: cancel button no longer accidentally submits valid form - #21898
Open
ercultimate wants to merge 2 commits into
Open
fix: cancel button no longer accidentally submits valid form#21898ercultimate wants to merge 2 commits into
ercultimate wants to merge 2 commits into
Conversation
Some cancel buttons would submit their form, which could result in unintentional actions being performed if the form was in a valid state.
ercultimate
marked this pull request as ready for review
August 20, 2026 17:03
spartacus
 |
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-13596
|
| Run status |
|
| Run duration | 05m 06s |
| Commit |
|
| Committer | Eric Polesky |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
3
|
 |
0
|
 |
0
|
 |
103
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some cancel buttons could submit their form, which could result in unintentional actions being performed if the form was in a valid state.