Spike/base site approach b - #21854
Draft
sp94sap wants to merge 2 commits into
Draft
Conversation
Approach (b): createApplication() boots minimal Angular app once at startup, reuse Spartacus DI (SiteContextConfigInitializer + BaseSiteService) to resolve base sites. Cache TTL 60s, AbortController timeout 3s. Add: - BaseSiteResolver shared contract - AngularAppBaseSiteResolver (approach b impl) - bench harness (dedup-startup, cold-start, warm-resolve, concurrent, slow-occ) - Express llms.txt handler consuming resolver SPIKE only, not production code.
renderApplication() hits platformServer() — process-level singleton. Two overlapping renders throw "createPlatform called twice". Cap=1 serialises via fail-fast: first render proceeds, extras shed with ConcurrencyLimitError → 503 + Retry-After. Also fixes deep core/src/… imports to core/public_api barrel.
Contributor
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.