fix: CXSPA-13801-11830: clean e2e - #21822
Draft
i53577 wants to merge 61 commits into
Draft
Conversation
Contributor
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
i53577
marked this pull request as ready for review
July 30, 2026 08:22
i53577
changed the title
i53577
changed the title
Contributor
E2E Tests Failed ❌Commit: b095fa0 |
Contributor
Merge Checks Failed |
…fects `defer(() => EMPTY)` in individual effects was insufficient: NgRx's `EffectSources.toActions()` wraps all effects with `materialize()` and merges them inside a long-lived `exhaustMap` that runs inside Angular's zone. Even when each effect completes immediately, the outer subscription chain keeps the zone perpetually unstable, preventing `ApplicationRef.isStable` from emitting and causing Cypress `cy.wait()` to time out. Implementing `OnRunEffects.ngrxOnRunEffects` and returning `EMPTY` when disabled causes NgRx's `resolveEffectSource` to pass `EMPTY` to `exhaustMap`, which completes synchronously — no Zone.js pending task is created. Also switch `takeUserId(true)` to `getUserId().pipe(filter, take(1))` to avoid emitting the anonymous user ID during token refresh.
i53577
marked this pull request as ready for review
July 31, 2026 03:46
Contributor
E2E Tests Failed ❌Commit: 93bb81c |
Contributor
Merge Checks Failed |
The previous glob `path: '.../cms/pages?lang=en&curr=*'` assumes query
parameters are serialised as lang-first. Adding B2bUnitSelectionOccModule
changes Angular's OccConfig merge order, flipping the serialisation to
curr-first (?curr=USD&lang=en), so the glob never matches and
cy.wait('@gethomepage') times out with "No request ever occurred".
The attempted fix using `pathname` also failed because Cypress treats the
`pathname` field as a literal string — the `*` in `users/*/cms/pages` was
matched as a literal asterisk, not as a glob wildcard.
Fix: use `path: '.../cms/pages*'` — the `path` field supports minimatch
globs, so the trailing `*` accepts any query-string regardless of parameter
order. The homepage CMS request is uniquely identified by omitting a
pageLabelOrId parameter, so no query-string filter is needed.
i53577
marked this pull request as ready for review
July 31, 2026 09:08
Contributor
Merge Checks Failed |
i53577
marked this pull request as ready for review
July 31, 2026 09:16
Contributor
E2E Tests Failed ❌Commit: 60f00a8 |
Contributor
Merge Checks Failed |
…store navigation intercept Replace ngrxOnRunEffects(EMPTY) approach with per-effect defer(() => EMPTY) factory guards that skip the action pipeline when b2bUnitSelection.enabled is false. Restore the homepage CMS intercept pattern to path:'...pages?lang=en&curr=*'; the broader 'pages*' glob introduced in 89a5371 matched non-homepage CMS requests under Cypress 15 testIsolation, causing cy.wait('@gethomepage') to consume the wrong response.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.