fix(a11y): activate navigation components on space keyup - #21800
Draft
uroslates wants to merge 10 commits into
Draft
fix(a11y): activate navigation components on space keyup#21800uroslates wants to merge 10 commits into
uroslates wants to merge 10 commits into
Conversation
- Closes https://jira.tools.sap/browse/CXSPA-12782. - Addresses ACC- 270.16(Level A) _ SAP Composable Storefront_ Combo Box, Button Menu_ UI getting activated without releasing space key.
…782) - Replace native <select> with ng-select behind a11yNavigationSpaceKeyOnKeyUp toggle in SiteContextSelectorComponent and SiteThemeSwitcherComponent. Monkey-patch NgSelectComponent.handleKeyDown to defer Enter selection to keyup. Prevent Space from scrolling the page when dropdown is open. Add ng-select styles (z-index, alignment, high-contrast) to both components.
…up-with-switch-to-ngSelect
uroslates
marked this pull request as ready for review
July 27, 2026 16:17
Contributor
Merge Checks Failed |
…up-with-switch-to-ngSelect
uroslates
marked this pull request as ready for review
July 28, 2026 09:46
Contributor
Merge Checks Failed |
…up-with-switch-to-ngSelect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://jira.tools.sap/browse/CXSPA-12782.
Addresses ACC- 270.16(Level A) _ SAP Composable Storefront_ Combo Box, Button Menu_ UI getting activated without releasing space key.
QA Steps:
Expected Behavior:
Once
a11yNavigationSpaceKeyOnKeyUpfeature flag is enabled the issues should not be there! When off they are reproducible again.IMPORTANT: This PR is in addition to other custom components addresses Language/Currency & Theme native selector issues (which are Browser specific) by adding ngSelect for those (if toggle is ON).
NOTE: Its addition to PR #21781 (adds select -> ngSelect conversion on top of PR.j