fix: (CXSPA-12811) Button_ Focus lost on invoking UI.#21565
Open
StanislavSukhanov wants to merge 8 commits into
Open
fix: (CXSPA-12811) Button_ Focus lost on invoking UI.#21565StanislavSukhanov wants to merge 8 commits into
StanislavSukhanov wants to merge 8 commits into
Conversation
spartacus
 |
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
fix/CXSPA-12811-Button-Focus-lost-on-invoking-UI
|
| Run status |
|
| Run duration | 04m 16s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
3
|
 |
0
|
 |
0
|
 |
103
|
| View all changes introduced in this branch ↗︎ | |
Zeyber
suggested changes
Jun 23, 2026
Zeyber
left a comment
Zeyber
left a comment
Contributor
There was a problem hiding this comment.
This way of handling the focus change seems fine to me given how much DOM changing happens in this particular situation. We'd just need to feature toggle it of course as always since we changed the dialog method used.
| * If none exists, a temporary `tabindex="-1"` is added to the host so it can | ||
| * receive programmatic focus without joining the tab order. | ||
| */ | ||
| protected restoreFocus(element: HTMLElement): void { |
Contributor
There was a problem hiding this comment.
I'm wondering if this method is rather generic, it could be nice to have in the dialog service as well with a bit more of a descriptive method name for this particular case (ie. user modifying the url). Then it can be reused in other similar cases.
…t-on-invoking-UI' into fix/CXSPA-12811-Button-Focus-lost-on-invoking-UI
Contributor
Merge Checks Failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: https://jira.tools.sap/browse/CXSPA-12811