-
Notifications
You must be signed in to change notification settings - Fork 412
feat: CPQ configurator process backed by CPQ 2.0 API (CXSPA-13470) #21556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Larisa-Staroverova
wants to merge
19
commits into
develop
Choose a base branch
from
feature/support_cpq_v2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2c2a8b9
feat: CPQ configurator process backed by CPQ 2.0 API (CXSPA-12242)
Larisa-Staroverova ef6e3ad
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova faaaf37
feat: Refactoring I
Larisa-Staroverova 26991a7
feat: Refactoring II
Larisa-Staroverova 6f4434a
feat: Refactoring III
Larisa-Staroverova f217915
CXSPA-12242: Make sonar happy
Larisa-Staroverova 8219fbe
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova 7ce9fb6
CXSPA-13470: Refactoring I
Larisa-Staroverova 06b643e
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova d45616b
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova fa646e9
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova 2e732ff
CXSPA-13470: Enable retract option for CPQV2
Larisa-Staroverova d4aa2dd
CXSPA-13470: Refactoring I
Larisa-Staroverova 1c5ea77
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova e29b88a
Update feature-libs/product-configurator/rulebased/core/state/effects…
Larisa-Staroverova 8374700
CXSPA-13470: Refactor retract logic
Larisa-Staroverova 359db02
CXSPA-13470: Review feedback II
Larisa-Staroverova 12f1057
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova 50c074d
Merge branch 'develop' into feature/support_cpq_v2
Larisa-Staroverova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this method rather confusing. How do we ensure that this doesn't break the VC scenario or the CPQ V1 scenario?
E.g the handling of attributes: In case a group exists already, why are we still taking the attributes from the incoming group? And why does that only happen if attributes lenght is > 0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to this protected method that hopefully better explains why this method is required.