feat: added output management integration#161
Conversation
|
|
|
Hi. Could you give a more detailed description of this new feature for future reference? Also, is necessary that the title follows commit convention, for exemple: |
| # SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Integration-style unit tests for output management module.""" |
There was a problem hiding this comment.
Integration tests should be in a different folder, and be proper integration test, if possible, and if not possible, a justification must be given. You can look destination module integration tests to see an example.
| @@ -0,0 +1,959 @@ | |||
| # SAP Cloud SDK for Python - Output Management Service User Guide | |||
There was a problem hiding this comment.
[BLOCK] DC-02
user-guide.md missing ## Installation section
SDK Module Review
Findings (4)
4 finding(s): 1 posted as inline comment(s) on the affected lines, 3 not tied to a code line (listed above). Generated by sdk-review-skill · v1 |
Description
Output Management is a BTP shared service which has features like sending documents to external system in various channels like EDI/EMAIL/Print. As part of this, we are mainly concentrating on the email use case where one can send email via our framework along with attachments if necessary.
We are exposing capabilities via util methods of sending email as BTP destination based and via integrated MCP hub. When using the MCP Hub way, we are giving the capability to construct the required payload and invoke the util functions. When using the BTP destination way, we are giving the options to input the destination details and the payloads.
Related Issue
Closes #<issue_number>
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
If this PR introduces breaking changes, please describe:
Additional Notes
Add any additional context, screenshots, or information that would help reviewers.