You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following content is AI-generated and provides a summary of the pull request:
Context
This PR improves the review-spec-update skill to better align with proposed architecture decisions for spec-driven development.
What this PR does and why it is needed
Enhances the SKILL.md guide for reviewing spec updates with additional classification rules and a more complete quick checklist. Key improvements include:
New breaking-change rules added to the classification tables:
additionalProperties: false added to a request object → breaking
Changes to under-specified response objects ({}) → non-breaking
Shared schema splits (e.g. FooConfig → FooConfigInput + FooConfigOutput) → SDK-effort only unless the old type was exported
New "Schema-split impact check" section with a step-by-step guide for assessing downstream impact when a schema is split, including an illustrative example
Updated quick checklist with three new items:
additionalProperties: false additions require a [compat] changeset
Schema splits: exported old names need [compat]; unexported + no structural change → no action
Under-specified response changes confirmed as non-breaking and omitted from [compat]
Perspective callout clarifying the distinction between user-breaking changes (requiring [compat] changesets) and SDK-effort-only changes
Category: Chore
🔄 Regenerate and Update Summary
✏️ Insert as PR Description (deletes this comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes SAP/ai-sdk-js-backlog#ISSUENUMBER.
This changes improves compliance with proposed architecture decisions.
What this PR does and why it is needed