Skip to content

[SMBC] Update 2608 - #845

Merged
Markus1812 merged 3 commits into
SAP:mainfrom
sepp4me:main
Aug 24, 2026
Merged

[SMBC] Update 2608#845
Markus1812 merged 3 commits into
SAP:mainfrom
sepp4me:main

Conversation

@sepp4me

@sepp4me sepp4me commented Aug 14, 2026

Copy link
Copy Markdown
Member

No description provided.

@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Control Panel

Hi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
To interact with me, just use the following actions:

  • 📝 Summarize PR
  • 🔍 Review
  • 🗑️ Delete all bot comments and reviews

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is generally well-structured — it adds several new features (transport object, Fiori Elements app/hide-draft settings, tree table type, interactive row count mode, threshold/scroll threshold) and fixes a typo ("Confguration" → "Configuration"). The two substantive issues to address are: the missing $maxLength 31 annotation on transport_object (which the auto-generated schema already has, suggesting the schema was patched by hand or will diverge on next regeneration), and the $default values of '100'/'300' on the threshold/scroll_threshold integer fields which violate the default-validity rules since 0 is the ABAP initial value for TYPE i and none of the three escape rules are satisfied.

PR Bot Information

Version: 1.29.26

Comment thread file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
Comment thread file-formats/smbc/type/zif_aff_smbc_v1.intf.abap
Comment thread file-formats/smbc/type/zif_aff_smbc_v1.intf.abap

@Markus1812 Markus1812 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the update. Looks compatible.

@Markus1812
Markus1812 merged commit 24e6f22 into SAP:main Aug 24, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants