Update GSMP Object type - #842
Conversation
|
ilina.kareva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
|
Hi, thanks for the update on the AFF. In the PR, you have commits of two different mail addresses. Your personal gmail and your SAP address. That's why the cla-assistant is detecting two users. I think you can fix this by adding your SAP mail address to your GitHub account. (This way, you can also join the SAP organization if you want). After adding the mail, you should be able to let the cla-assistant recheck this PR and we should be good to go. Regarding the two changes in the PR:
A default value only helps if it already existed in the system before the new enum value was introduced: in that case, the file format implementation substitutes the unknown value with the field's default. But since execution_mode never had a default, adding one now wouldn't help the systems that are already out there — they were built without that fallback rule. So for those systems, adding extension is an incompatible change regardless. This gives us two options:
In either case, please also add a $default to ty_execution_mode now, so that any future additions to this enum stay compatible. Could you let me know whether GSMP is already in use anywhere? That would help us decide which way to go. The async change is fine either way. Thanks! |
Update object type GSMP