[SVIM] Add new object type SVIM - #836
Conversation
|
rename the examples folder from "example" to "examples" |
Done |
|
FYI: The example for SVIM was created manually by referring to the existing examples. |
|
Thank you for pushing your AFF and for posting the SAP GUI screenshots. I have a couple questions, as I have no idea what this transaction does: -do overview screen and single screen correspond to object types? I see they are clickable in SAP GUI. |
|
@shashank-yadav87 mentioning you here for visibility. please check my previous comment |
|
Hi @GuilhermeSaraiva96, the screen pertains to the maintenance dialog of a database table or a view. This maintenance dialog is used to maintain customizing data. Refer the following SAP Help link for the details. -do overview screen and single screen correspond to object types? I see they are clickable in SAP GUI. Refer the following SAP Help link for the details. |
|
DS_STORE file needs to be removed from the root folder |
done |
Markus1812
left a comment
There was a problem hiding this comment.
Hi, thanks for contributing! In general, the AFF looks good to me. I have one suggestion regarding consistency to other AFFs. Would be nice if you could change that. Otherwise, I don't think we have to do much here.
Markus1812
left a comment
There was a problem hiding this comment.
Thanks, the AFF looks good to me. Pinging another reviewer to double-check.
GuilhermeSaraiva96
left a comment
There was a problem hiding this comment.
Looks good to me as well
|
Thanks for approving. Would you be proceeding with the merge @Markus1812 ? |
schneidermic0
left a comment
There was a problem hiding this comment.
LGTM. I've just found a missing default value for the event types. This is not mandatory, but might help in the future to set a default value if new enum values are added.
403f05a
|
Hi @GuilhermeSaraiva96 @Markus1812 @schneidermic0 , please let me know in case there are any further issues to be addressed. If not, can you please proceed with the approval and merge? Thanks, |
Markus1812
left a comment
There was a problem hiding this comment.
Thanks for the update. This AFF is only for defining a transport format, no server-driven editor at the moment, right?
Yes. No server driven editor at the moment. Currently, no ABAP File Format (AFF) is defined for SVIM. This has two consequences:
|
Hi, attaching the ABAP screens from which the attributes and events are derived for this AFF. Example view 'V_T005_BAS' is considered here.
