BDEF: fix typo - #823
Open
larshp wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Not ready to approve
Renaming a JSON field in a v1 format is an incompatible change and should be introduced as a v2 format (or explicitly support both names for backward compatibility).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR corrects a misspelled BDEF field name (extendedBehaviorDefintion → extendedBehaviorDefinition) across the ABAP type source, the generated JSON Schema, and an example JSON file.
Changes:
- Renamed the
ty_mainfield inzif_aff_bdef_v1to fix the spelling. - Updated the BDEF v1 JSON Schema property name accordingly.
- Updated the BDEF example JSON to use the corrected property name.
File summaries
| File | Description |
|---|---|
| file-formats/bdef/type/zif_aff_bdef_v1.intf.abap | Renames the ABAP type component that drives JSON field naming in generated schema. |
| file-formats/bdef/examples/z_aff_example_bdef_extension.bdef.json | Updates the example to the corrected JSON property name. |
| file-formats/bdef/bdef-v1.json | Renames the schema property to match the corrected field name. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Low
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
| ] | ||
| }, | ||
| "extendedBehaviorDefintion": { | ||
| "extendedBehaviorDefinition": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incompatible, add as version 2 instead?