Skip to content

Fix ContextTest comparison of ContextActivities signatures. #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix ContextTest comparison of ContextActivities signatures. #93

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
758a9c5
Fix comparison of ContextActivities signatures.
pondermatic Nov 12, 2017
889dada
Change PHPUnit_Framework_TestCase to PHPUnit\Framework\TestCase.
pondermatic Nov 13, 2017
a916e3d
Change PHPUnit version.
pondermatic Nov 13, 2017
f203ab3
Update "too few arguments" tests for PHP 7.1.
pondermatic Nov 13, 2017
ddd2f0a
Fix HHVM array to string issue.
pondermatic Nov 13, 2017
4f3f941
Merge branch 'PHPUnit' into ContextTest
pondermatic Nov 13, 2017
3508cc6
Revert "Merge branch 'PHPUnit' into ContextTest"
pondermatic Nov 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions tests/ContextTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,15 @@ public function testCompareWithSignature() {
[ 'account' => [ 'homePage' => COMMON_ACCT_HOMEPAGE, 'name' => COMMON_ACCT_NAME ]]
);
$contextActivities1 = new ContextActivities(
[ 'parent' => [ COMMON_ACTIVITY_ID ]]
[
'parent' => [ COMMON_ACTIVITY_ID ]
]
);
$contextActivities2 = new ContextActivities(
[ 'parent' => [ COMMON_ACTIVITY_ID . '/parent' ]],
[ 'grouping' => [ COMMON_ACTIVITY_ID ]]
[
'parent' => [ COMMON_ACTIVITY_ID . '/parent' ],
'grouping' => [ COMMON_ACTIVITY_ID ]
]
);
$ref1 = new StatementRef(
[ 'id' => Util::getUUID() ]
Expand Down Expand Up @@ -270,7 +274,7 @@ public function testCompareWithSignature() {
'description' => 'contextActivities only: mismatch',
'objArgs' => ['contextActivities' => $contextActivities1 ],
'sigArgs' => ['contextActivities' => $contextActivities2 ],
'reason' => 'Comparison of contextActivities failed: Comparison of parent failed: array lengths differ'
'reason' => 'Comparison of contextActivities failed: Comparison of grouping failed: array lengths differ'
],
[
'description' => 'revision only: mismatch',
Expand Down Expand Up @@ -324,7 +328,7 @@ public function testCompareWithSignature() {
'description' => 'full: contextActivities mismatch',
'objArgs' => $full,
'sigArgs' => array_replace($full, ['contextActivities' => $contextActivities2]),
'reason' => 'Comparison of contextActivities failed: Comparison of parent failed: array lengths differ'
'reason' => 'Comparison of contextActivities failed: Comparison of grouping failed: array lengths differ'
],
[
'description' => 'full: revision mismatch',
Expand Down