-
Notifications
You must be signed in to change notification settings - Fork 59
Add query_size_lod and query_size methods to SampledImage #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add query_size_lod for non-multisampled sampled images (Sampled=1) - Add query_size for multisampled sampled images - Add missing HasQuerySize trait implementations for Sampled::Yes - Add tests for both methods
I used this in a shader and it worked. |
Without this cubemaps were broken...we were returning UVec3 but spirv validation required UVec2.
This was broken for cubemaps, pushed a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, didn't check the new impl against spec, I'll just assume compiletests would have caught it.
You're missing compiletest for 1D+arrayed, 3d arrayed and buffer images. (And rect images but those are illegal in vulkan iirc, so who cares)
@LegNeato how did this merge into main if the run failed? |
@Firestar99 No clue! I think it is a github bug because it also seemed to have dropped my updated amended commit that fixed the CI? |
The fix is to add This happens over and over again, and GitHub engineers do not seem to care enough to fix it, offering an obscure workaround instead. |
Fixes #190