Re-enable path-tracer.
#332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rust-GPU#313 I disabled all the code relying on OptiX. I subsequently learned that `path-tracer`'s use of OptiX is optional. `path-tracer` is a big and good example, so this commit re-enables it, but with the OptiX-specific bits commented out. (Commenting out code is crude, but I had trouble with features, as detailed within the commit. This is better than nothing.)
Collaborator
Author
|
The test failure seems to be that Docker is failing to download an image. It's only on x86-64, the ARM equivalent is fine. Whatever it is, it's definitely unrelated to this PR. |
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Dec 9, 2025
It was added in Rust-GPU#199, in preparation for running GPU tests on non-GitHub resources. But that seems unlikely to happen now, so it's just added complexity and potential for unexplained failures (as seen in Rust-GPU#332). This commit removes it. We can always reinstate it if necessary.
Collaborator
Author
|
The failing test here won't be a problem after #338 lands. |
LegNeato
approved these changes
Dec 10, 2025
nnethercote
added a commit
to nnethercote/Rust-CUDA
that referenced
this pull request
Dec 11, 2025
The merging of two unintentionally interdependent PRs left `path-tracer` in a broken state. - Rust-GPU#335 updated it from edition 2018 to 2024, while it was disabled (commented out). - Rust-GPU#332 re-enabled it. This left it marked as using edition 2024 but without the appropriate changes for edition 2024. This commit makes those changes.
Merged
LegNeato
pushed a commit
that referenced
this pull request
Dec 11, 2025
The merging of two unintentionally interdependent PRs left `path-tracer` in a broken state. - #335 updated it from edition 2018 to 2024, while it was disabled (commented out). - #332 re-enabled it. This left it marked as using edition 2024 but without the appropriate changes for edition 2024. This commit makes those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #313 I disabled all the code relying on OptiX. I subsequently learned that
path-tracer's use of OptiX is optional.path-traceris a big and good example, so this commit re-enables it, but with the OptiX-specific bits commented out. (Commenting out code is crude, but I had trouble with features, as detailed within the commit. This is better than nothing.)