Fix copy construction and assignment of Pieces
#4068
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointers stored in Pieces::pieces_vector refer to objects with lifetimes tied to Pieces::handle. This commit also removes the move constructor for Pieces, as it's equivalent to the copy constructor. gcc/rust/ChangeLog: * ast/rust-fmt.cc (Pieces::Pieces): Reconstruct pieces_vector when copying, remove move constructor. (Pieces::operator=): Reconstruct pieces_vector when copying. * ast/rust-fmt.h (Pieces::Pieces): Remove move constructor. Signed-off-by: Owen Avery <[email protected]>
|
I've removed the move constructor instead of creating an accurate implementation, as I'd want to be very careful about maintaining invariants on a moved-from |
|
Superseded by #4074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers stored in
Pieces::pieces_vectorrefer to objects with lifetimes tied toPieces::handle. This commit also removes the move constructor for Pieces, as it's equivalent to the copy constructor.