Implement unused variable checker on HIR #4055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakupan102
changed the title
sakupan102
force-pushed
the
unused-var-checker
branch
from
c2bb066 to
038d637
Compare
gcc/rust/ChangeLog: * Make-lang.in: New file. * checks/lints/unused-var/rust-unused-var-checker.cc (UnusedVarChecker): Implement unused variable checker. * checks/lints/unused-var/rust-unused-var-checker.h (UnusedVarChecker): Implement unused variable checker. * checks/lints/unused-var/rust-unused-var-collector.cc (UnusedVarCollector): Implement unused variable collector. * checks/lints/unused-var/rust-unused-var-collector.h (UnusedVarCollector): Implement unused variable collector. * checks/lints/unused-var/rust-unused-var-context.cc (UnusedVarContext): Implement unused variable context. * checks/lints/unused-var/rust-unused-var-context.h (UnusedVarContext): Implement unused variable context. Signed-off-by: Ryutaro Okada <[email protected]>
sakupan102
force-pushed
the
unused-var-checker
branch
from
038d637 to
f27c7a7
Compare
CohenArthur
reviewed
Aug 11, 2025
Comment on lines
+24
to
+31
| UnusedVarContext * | ||
| UnusedVarContext::get () | ||
| { | ||
| static UnusedVarContext *instance; | ||
| if (instance == nullptr) | ||
| instance = new UnusedVarContext (); | ||
| return instance; | ||
| } |
There was a problem hiding this comment.
I think this is fine but we should also check if we can do without a global variable
| UnusedVarCollector::visit (HIR::LetStmt &stmt) | ||
| { | ||
| HIR::Pattern &pattern = stmt.get_pattern (); | ||
| collect_variable (pattern); |
There was a problem hiding this comment.
can't we visit instead here? mabye I'm missing something but I think all patterns should create variables to check for, so we could just do visit(pattern) and then create visitors for all our kinds of patterns instead of manually dispatching like in collect_variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check-rustpasses locallyclang-format