-
Notifications
You must be signed in to change notification settings - Fork 184
ci: Compile with checking enabled #4002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
It looks like the sourceware runners are compiling with checking, and that may be why they error out where we don't. Regardless, this should make our CI more sensitive to bugs. ChangeLog: * .github/workflows/ccpp.yml: Configure with --enable-checking=yes. * .github/workflows/ccpp32alpine.yml: Likewise. Signed-off-by: Owen Avery <[email protected]>
This doesn't help resolve https://builder.sourceware.org/buildbot/#/builders/27 like I was hoping, but it should still be nice to have. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build of multilibs is enabled by default, and also checking (yes,extra
) is enabled by default, gcc/configure.ac
:
# Determine the default checks.
if test x$is_release = x ; then
ac_checking_flags=yes,extra
else
ac_checking_flags=release
fi])
The fails are for a 32-bit x86 host system. We have |
Haha! "GCC Rust build and test (Alpine 32-bit) / build-alpine-32bit-and-check-alpine-32bit" produced:
..., because of That test case was added in #3915, #1247 commit 9526906 "gccrs: fix bad monomophization of generic paths". @philberty: What's the rationale behind the |
@tschwinge this is my excitement where this goal test case now works but its uncovered a bug with how we do the intrinsic u32 rotate which is causing this ICE on m32 I think the issue as far as i can tell is we need to change the shift count to be masked by the size of the type but it was an related change to that patch. I'll open an issue |
No description provided.