gccrs: Implement compilation of IdentifierPattern's subpattern bindings #3822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * ast/rust-ast-collector.cc: Rename get_pattern_to_bind to get_subpattern * ast/rust-ast-visitor.cc: Ditto. * ast/rust-pattern.h: Ditto. * expand/rust-cfg-strip.cc: Ditto. * hir/rust-ast-lower-pattern.cc: Ditto. Signed-off-by: Yap Zhi Heng <[email protected]>
gcc/rust/ChangeLog: * resolve/rust-ast-resolve-pattern.cc: Implement name resolution for IdentifierPattern's subpattern. * resolve/rust-late-name-resolver-2.0.cc: Ditto, but for nr2. Signed-off-by: Yap Zhi Heng <[email protected]>
gcc/rust/ChangeLog: * backend/rust-compile-pattern.cc: Add support for IdentifierPattern's subpattern under CompilePatternBindings. Signed-off-by: Yap Zhi Heng <[email protected]>
P-E-P
reviewed
Jun 16, 2025
| @@ -250,6 +250,11 @@ visit_identifier_as_pattern (NameResolutionContext &ctx, | |||
| void | |||
| Late::visit (AST::IdentifierPattern &identifier) | |||
| { | |||
| if (identifier.has_subpattern ()) | |||
There was a problem hiding this comment.
Do we really need a condition check over this ? Calling DefaultResolver::visit(identifier) directly would help future changes and let the condition in the default visitor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes renaming of
get_pattern_to_bindtoget_subpatternwhich I missed out in my previous PR.I'm aware that there are still other visit functions that lack support for
subpattern- some changes for those are currently under my draft branch in my fork which I'll eventually get around to fully implementing and testing. For now, I think I want to move on and focus on implementing minimal support for other unsupported patterns first.make check-rustpasses locallyclang-formatgcc/testsuite/rust/