gccrs: Add initial compilation support for IdentifierPattern's subpatterns #3814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * backend/rust-compile-pattern.cc: Add CheckExpr compilation for IdentifierPattern with subpattern. * backend/rust-compile-pattern.h: Modify IdentifierPattern's visit func to support the above. * typecheck/rust-hir-type-check-pattern.cc: Add typechecking support for the changes above. Signed-off-by: Yap Zhi Heng <[email protected]>
gcc/rust/ChangeLog: * ast/rust-ast-collector.cc: Rename to_bind to subpattern. * ast/rust-ast-visitor.cc: Ditto. * ast/rust-pattern.cc: Ditto. * ast/rust-pattern.h: Ditto. * backend/rust-compile-pattern.cc: Ditto. * expand/rust-cfg-strip.cc: Ditto. * hir/rust-ast-lower-pattern.cc: Ditto. * hir/rust-hir-dump.cc: Ditto. * hir/tree/rust-hir-pattern.h: Ditto. * hir/tree/rust-hir.cc: Ditto. * typecheck/rust-hir-type-check-pattern.cc: Ditto. Signed-off-by: Yap Zhi Heng <[email protected]>
Polygonalr
force-pushed
the
identifierpattern-clean
branch
from
1f5fb1d to
37a5e70
Compare
CohenArthur
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
good job @Polygonalr!! this PR looks really nice and the test cases are really good.
Comment on lines
+429
to
+438
| { | ||
| if (pattern.has_subpattern ()) | ||
| { | ||
| check_expr = CompilePatternCheckExpr::Compile (pattern.get_subpattern (), | ||
| match_scrutinee_expr, ctx); | ||
| } | ||
| else | ||
| { | ||
| check_expr = boolean_true_node; | ||
| } |
Comment on lines
+48
to
-53
| void visit (HIR::IdentifierPattern &) override; | ||
|
|
||
| // Always succeeds | ||
| void visit (HIR::IdentifierPattern &) override | ||
| { | ||
| check_expr = boolean_true_node; | ||
| } |
There was a problem hiding this comment.
good job, this is always a good cleanup - we try prioritizing implementations in .cc files rather than .h files
Comment on lines
+542
to
+544
| { | ||
| TypeCheckPattern::Resolve (pattern.get_subpattern (), parent); | ||
| } |
There was a problem hiding this comment.
GCC style is to avoid braces for one-line if blocks, but this is a nitpick - feel free to disregard
Suggested change
| { | |
| TypeCheckPattern::Resolve (pattern.get_subpattern (), parent); | |
| } | |
| TypeCheckPattern::Resolve (pattern.get_subpattern (), parent); |
|
Looks like you might be missing some changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds initial support for compilation of IdentifierPattern's subpattern. For now, tested and works with simple
LiteralPatternsubpatterns; more complex subpatterns require further testing.make check-rustpasses locallyclang-formatgcc/testsuite/rust/Reviewers: 1st commit contains the actual changes, 2nd commit only contains variable renaming.