Skip to content

Chore/build optimization v2 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

onelrian
Copy link
Collaborator

@onelrian onelrian commented Apr 4, 2025

Added custom linker configurations in .cargo/config.toml:

  • Linux: Uses mold via clang (-fuse-ld=/usr/bin/mold)

  • macOS: Uses lld with -fuse-ld=lld

  • Windows (MSVC): Uses lld-link

Updated docs/build_optimization.md:

  • Added clear, concise setup instructions for installing and verifying each linker across all platforms

  • Windows users can now add lld-link.exe to their PATH via a single command

@onelrian
Copy link
Collaborator Author

onelrian commented Apr 4, 2025

@Christiantyemele
There is readme file on the main
So I can't add info about the lnker there for now

Copy link
Member

@Blindspot22 Blindspot22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just ensure all the new changes requested here were met. After that, just hit me up for an approval 👍

@onelrian onelrian requested a review from Blindspot22 April 4, 2025 09:00
@bansikah22
Copy link
Collaborator

@onelrian will test this locally soon

@onelrian
Copy link
Collaborator Author

onelrian commented Apr 4, 2025

Let me know if you run into any issues or need help.

@onelrian onelrian linked an issue Apr 4, 2025 that may be closed by this pull request
@Dericko681
Copy link
Collaborator

works well

Copy link
Collaborator

@chojuninengu chojuninengu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @onelrian

@Christiantyemele
Copy link
Collaborator

sorry @onelrian lets keep this PR as a draft for now

@Christiantyemele Christiantyemele marked this pull request as draft April 8, 2025 12:11
@onelrian onelrian marked this pull request as ready for review April 8, 2025 12:19
@onelrian onelrian marked this pull request as draft April 8, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Build and Link time
7 participants