Add support for Rails 7.1 and 7.2 #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmijos
commented
Sep 24, 2024
spec/configuration_spec.rb
Outdated
| @@ -138,7 +138,7 @@ | |||
|
|
|||
| context "when passed an invalid value" do | |||
| it "should raise an ArgumentError" do | |||
| expect(lambda{MoneyRails.rounding_mode = "booyakasha"}).to raise_error(ArgumentError, 'booyakasha is not a valid rounding mode') | |||
| expect { MoneyRails.rounding_mode = "booyakasha" }.to raise_error(ArgumentError, 'booyakasha is not a valid rounding mode') | |||
There was a problem hiding this comment.
This was an RSpec deprecation warning
sunny
approved these changes
Sep 24, 2024
Merged
|
@schmijos would you mind rebasing your branch with |
schmijos
force-pushed
the
add-rails-7_x-support
branch
2 times, most recently
from
c10ed9b to
b92db01
Compare
schmijos
force-pushed
the
add-rails-7_x-support
branch
from
b92db01 to
9c5a4bf
Compare
diff --git a/gemfiles/rails7.1.gemfile b/gemfiles/rails7.1.gemfile new file mode 100644 index 0000000..3951f70 --- /dev/null +++ b/gemfiles/rails7.1.gemfile @@ -0,0 +1,17 @@ +source 'https://rubygems.org' + +gem 'rails', '~> 7.1.0' +gem 'sprockets-rails' +gem 'i18n', '~> 1.6' + +platforms :jruby do + gem "activerecord-jdbc-adapter" + gem "activerecord-jdbcsqlite3-adapter" + gem "jruby-openssl" +end + +platforms :ruby do + gem "sqlite3", "~> 1.4" +end + +gemspec path: '../' diff --git a/gemfiles/rails7.2.gemfile b/gemfiles/rails7.2.gemfile new file mode 100644 index 0000000..7050731 --- /dev/null +++ b/gemfiles/rails7.2.gemfile @@ -0,0 +1,17 @@ +source 'https://rubygems.org' + +gem 'rails', '~> 7.2.0' +gem 'sprockets-rails' +gem 'i18n', '~> 1.6' + +platforms :jruby do + gem "activerecord-jdbc-adapter" + gem "activerecord-jdbcsqlite3-adapter" + gem "jruby-openssl" +end + +platforms :ruby do + gem "sqlite3", "~> 2.0" +end + +gemspec path: '../'
yukideluxe
force-pushed
the
add-rails-7_x-support
branch
from
9c5a4bf to
d917547
Compare
yukideluxe
reviewed
Jul 11, 2025
There was a problem hiding this comment.
@schmijos I just removed the Ruby 3.0 test and it's all green now 😊 Based on the discussion here we will just drop support for Ruby 3.0 since the new money-rails version will depend on the newest money version and that requires at least 3.1 ✌🏻
I might simplify a bit the new gemspecs you added based on the changes I've done [here (https://github.com//pull/719) but I am merging your PR as it is!
yukideluxe
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new Gemfiles and bumps minimal versions.