-
Notifications
You must be signed in to change notification settings - Fork 8
Faster filtering, mapping, limiting, skipping and wrapping #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jacoscaz
wants to merge
35
commits into
RubenVerborgh:main
from
jacoscaz:faster-filtering-mapping-limiting-skipping-wrapping-union
Closed
Faster filtering, mapping, limiting, skipping and wrapping #57
jacoscaz
wants to merge
35
commits into
RubenVerborgh:main
from
jacoscaz:faster-filtering-mapping-limiting-skipping-wrapping-union
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end events on promisified sources
…atorLike, adds option to prioritize ES2015 Iterable and Iterator while wrapping
…m ES2015 Iterator
This was referenced Mar 30, 2022
Owner
Collaborator
Author
Yep, we can always break it down into separate PRs later on, if needed. |
…wrapping and synchronous transform
…Iterator to mature
introduce maybe map and do some refactoring
…onousTransformIterator
… for WrappingIterator
Collaborator
Author
|
Closing this in favor of #59 and the plan detailed in #44 (comment) . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all work from #48 , #49 , #53,
#54and #55 done by @jeswr and I on performance. It's not ready to be merged but it is ready for reviews and feedbacks.Jesse and I opted to merge everything into one branch as, having validated all of these PRs individually, we now need them in aggregate to measure their overall effect and to facilitate testing within other projects, including Jesse's performance evaluations for his honors work.
As for the state of this PR, all
asynciteratortests are passing and so are Comunica'sspec:queryandspec:updatesuites. As per #49 (comment) , these are the issues within Comunica: