more subshell checks #8400
Draft
more subshell checks #8400
+418
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…pression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
hannesrudolph
added
the
Issue/PR - Triage
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| return `__QUOTE_${quotes.length - 1}__` | ||
| }) | ||
|
|
||
| // Handle fish-style command substitutions and POSIX subshell grouping: ( ... ) |
There was a problem hiding this comment.
[P1] In the bare '(' handler for grouping/fish substitutions, arithmetic evaluation '(( ... ))' (without a preceding '$') can be misclassified as a subshell, surfacing faux sub-commands (e.g., 'count++'). Add a guard to keep ((...)) intact rather than extracting it as a subshell.
| // Examples: *(+whoami), *(.+{'whoami'}), *(+"whoami") | ||
| // Treat + followed by a non-digit token inside a qualifier list as executable (exclude numeric-only like (+1)) | ||
| // Anchor to a preceding glob meta to reduce false positives. | ||
| const zshGlobQualifierPlusShorthand = |
There was a problem hiding this comment.
[P2] The zsh glob +shorthand detector may overmatch numeric-only tokens when wrapped (e.g., '(+{1})', '(+"1")'). Consider refining to ignore pure-digit tokens in those branches and add negative tests to pin behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I may have let gpt-5 get too far off the leash with this one.