Skip to content

fix: initialize enableReasoningEffort default value to fix save butto… #7100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wjq990112
Copy link

@wjq990112 wjq990112 commented Aug 14, 2025

…n state

Related GitHub Issue

Closes: #7099

Roo Code Task Context (Optional)

Description

Since enableReasoningEffort is undefined initially, it will hit this condition:

https://github.com/wjq990112/Roo-Code/blob/main/webview-ui/src/components/settings/SettingsView.tsx#L232

isInitialSync will be true when the user clicks the checkbox for "Enable reasoning", so that the "Save" button will not change to enable.

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Initialize enableReasoningEffort to false in ThinkingBudget to fix save button state when checkbox is first checked.

  • Behavior:
    • Initialize enableReasoningEffort to false in ThinkingBudget to fix save button state when checkbox is first checked.
    • Uses useEffect to set default value if enableReasoningEffort is undefined and isReasoningBudgetSupported is true.

This description was created by Ellipsis for 3cede8d. You can customize this summary. It will automatically update as commits are pushed.

@wjq990112 wjq990112 requested review from mrubens, cte and jr as code owners August 14, 2025 14:56
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Aug 14, 2025
@wjq990112 wjq990112 force-pushed the fix/save-button-status-accroding-to-enable-reasoning branch from 3cede8d to 9ece3bb Compare August 14, 2025 14:57
Copy link

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I've reviewed the changes and the fix correctly addresses the save button issue. The initialization of enableReasoningEffort to false prevents the isInitialSync logic from incorrectly treating user interactions as initialization. I have a couple of suggestions for improvement that you might want to consider.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 14, 2025
@daniel-lxs
Copy link
Collaborator

Fixed by #7113

@daniel-lxs daniel-lxs closed this Aug 16, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Aug 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cannot enable "Save" button when the user click "Enable reasoning"
3 participants